Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: components/ntp_snippets/breaking_news/subscription_json_request.h

Issue 2918513002: [NTP::Push] Add the classes for sending a breaking news subscription request (Closed)
Patch Set: bauerb@ fhorschig@ comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/breaking_news/subscription_json_request.h
diff --git a/components/ntp_snippets/breaking_news/subscription_json_request.h b/components/ntp_snippets/breaking_news/subscription_json_request.h
new file mode 100644
index 0000000000000000000000000000000000000000..4850b98cbbc12aa1df4928338ecf4cab92d5beb0
--- /dev/null
+++ b/components/ntp_snippets/breaking_news/subscription_json_request.h
@@ -0,0 +1,91 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NTP_SNIPPETS_BREAKING_NEWS_SUBSCRIPTION_JSON_REQUEST_H_
+#define COMPONENTS_NTP_SNIPPETS_BREAKING_NEWS_SUBSCRIPTION_JSON_REQUEST_H_
+
+#include <memory>
+#include <string>
+#include <utility>
+
+#include "base/callback.h"
+#include "base/memory/weak_ptr.h"
+#include "base/optional.h"
+#include "base/time/time.h"
+#include "components/ntp_snippets/status.h"
+#include "components/translate/core/browser/language_model.h"
+#include "google_apis/gaia/oauth2_token_service.h"
+#include "net/http/http_request_headers.h"
+
+namespace ntp_snippets {
+
+namespace internal {
+
+// A single request to subscribe for breaking news via GCM. The Request has to
+// stay alive in order to be successfully completed.
+class SubscriptionJsonRequest : public net::URLFetcherDelegate {
+ public:
+ // A client can expect a message in the status only, if there was any error
+ // during the subscription. In successful cases, it will be an empty string.
+ using CompletedCallback =
+ base::OnceCallback<void(const ntp_snippets::Status& status)>;
+
+ // Builds non-authenticated SubscriptionJsonRequests.
+ class Builder {
+ public:
+ Builder();
+ Builder(Builder&&);
+ ~Builder();
+
+ // Builds a Request object that contains all data to fetch new snippets.
+ std::unique_ptr<SubscriptionJsonRequest> Build() const;
+
+ Builder& SetToken(const std::string& token);
+ Builder& SetUrl(const GURL& url);
+ Builder& SetUrlRequestContextGetter(
+ const scoped_refptr<net::URLRequestContextGetter>& context_getter);
+
+ private:
+ std::string BuildHeaders() const;
+ std::string BuildBody() const;
+ std::unique_ptr<net::URLFetcher> BuildURLFetcher(
+ net::URLFetcherDelegate* request,
+ const std::string& headers,
+ const std::string& body) const;
+
+ // GCM subscribtion token obtain from GCM driver (instanceID::getToken())
+ std::string token_;
+ // TODO(mamir): Additional fields to be added: country, language
+
+ GURL url_;
+ scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
+ };
+
+ ~SubscriptionJsonRequest() override;
+
+ // Starts a async request. The callback is invoked when the request succeeds,
Bernhard Bauer 2017/06/01 20:34:51 Tiny nit: "an async request" :)
mamir 2017/06/02 09:06:49 Done.
+ // fails or gets destroyed.
+ void Start(CompletedCallback callback);
+
+ private:
+ friend class Builder;
+ SubscriptionJsonRequest();
+ // URLFetcherDelegate implementation.
+ void OnURLFetchComplete(const net::URLFetcher* source) override;
+
+ // The fetcher for subscribing.
+ std::unique_ptr<net::URLFetcher> url_fetcher_;
+
+ // The callback to notify when URLFetcher finished and results are available.
+ // When the request is finished/aborted/destroyed, it's called in the dtor!
+ CompletedCallback request_completed_callback_;
+
+ DISALLOW_COPY_AND_ASSIGN(SubscriptionJsonRequest);
+};
+
+} // namespace internal
+
+} // namespace ntp_snippets
+
+#endif // COMPONENTS_NTP_SNIPPETS_BREAKING_NEWS_SUBSCRIPTION_JSON_REQUEST_H_
« no previous file with comments | « components/ntp_snippets/BUILD.gn ('k') | components/ntp_snippets/breaking_news/subscription_json_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698