components/ntp_snippets/breaking_news/subscription_request_params.cc - Issue 2918513002: [NTP::Push] Add the classes for sending a breaking news subscription request

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/breaking_news/subscription_request_params.cc

Issue 2918513002: [NTP::Push] Add the classes for sending a breaking news subscription request (Closed)

Patch Set: Adding the tests Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/ntp_snippets/breaking_news/subscription_request_params.h"
	fhorschig 2017/05/31 14:51:14 Looking at this rather sparse implementation ... w Looking at this rather sparse implementation ... we could inline the whole class into the json_request class ... likely even into the anonymous namespace. (The original request just published this to test the request param building) mamir 2017/05/31 18:46:04 Acknowledged. Show quoted text On 2017/05/31 14:51:14, fhorschig wrote: > Looking at this rather sparse implementation ... we could inline the whole class > into the json_request class ... likely even into the anonymous namespace. > > (The original request just published this to test the request param building) Acknowledged.
	6

	7 namespace ntp_snippets {

	8

	9 SubscriptionRequestParams::SubscriptionRequestParams() = default;

	10 SubscriptionRequestParams::SubscriptionRequestParams(

	11 const SubscriptionRequestParams&) = default;

	12 SubscriptionRequestParams::~SubscriptionRequestParams() = default;

	13

	14 } // namespace ntp_snippets

OLD	NEW