Call write() within render_pictures but not bench_pictures

Call write() within render_pictures but not bench_pictures

BUG=skia:2584
Committed: http://code.google.com/p/skia/source/detail?r=14837

[epoger, 2014-05-21 19:25:37]

Brian/Rob: first LG wins

https://codereview.chromium.org/291843010/diff/1/tools/PictureRenderer.cpp
File tools/PictureRenderer.cpp (right):

https://codereview.chromium.org/291843010/diff/1/tools/PictureRenderer.cpp#ne...
tools/PictureRenderer.cpp:400: return write(fCanvas, fWritePath, fMismatchPath,
fInputFilename, fJsonSummaryPtr,
The changes in here were exactly what Brian sent me in
https://codereview.chromium.org/286903014/ ('Remove calls to write() from
bench_pictures timing loop').

I tried to add the unittest disablement as a patch to that same CL, but Rietveld
wouldn't let me:
Issue creation errors: {'user': ["You (epoger@google.com) don't own this issue
(286903014)"]}

[epoger, 2014-05-21 19:32:57]

Actually, hold off on the review, please.  I'm going to see if there is some way
I can keep render_pictures working.  I remembered that Cluster Telemetry uses
it. :-/

[epoger, 2014-05-21 20:16:02]

[renamed the CL]

OK, Brian/Rob, please review patchset 2.  It should keep render_pictures
operating as usual, but remove the offending calls in bench_pictures.

[robertphillips, 2014-05-21 20:28:10]

lgtm

[epoger, 2014-05-21 20:29:03]

OK, Ben, whenever you're ready to deal with the rebaselining, check the box!

[benchen, 2014-05-21 20:29:41]

On 2014/05/21 20:29:03, epoger wrote:
> OK, Ben, whenever you're ready to deal with the rebaselining, check the box!

cool, thanks for the quick work!

[benchen, 2014-05-22 00:29:34]

The CQ bit was checked by bensong@google.com

[commit-bot: I haz the power, 2014-05-22 00:30:22]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/epoger@google.com/291843010/20001

[commit-bot: I haz the power, 2014-05-22 00:36:07]

Change committed as 14837