Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Issue 291843009: Move multipart_response_delegate_unittest from webkit/ to content/ (Closed)

Created:
6 years, 7 months ago by pilgrim_google
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move multipart_response_delegate_unittest from webkit/ to content/ BUG=338338 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273093

Patch Set 1 #

Total comments: 1

Patch Set 2 : nits #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -684 lines) Patch
A + content/child/multipart_response_delegate_unittest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download
M webkit/child/multipart_response_delegate.h View 2 chunks +5 lines, -3 lines 0 comments Download
D webkit/child/multipart_response_delegate_unittest.cc View 1 chunk +0 lines, -676 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pilgrim_google
6 years, 7 months ago (2014-05-21 13:47:00 UTC) #1
jam
lgtm with nit https://codereview.chromium.org/291843009/diff/1/content/child/multipart_response_delegate_unittest.cc File content/child/multipart_response_delegate_unittest.cc (right): https://codereview.chromium.org/291843009/diff/1/content/child/multipart_response_delegate_unittest.cc#newcode47 content/child/multipart_response_delegate_unittest.cc:47: } // namespace content nit: put ...
6 years, 7 months ago (2014-05-21 17:00:55 UTC) #2
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 7 months ago (2014-05-21 17:20:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/291843009/20001
6 years, 7 months ago (2014-05-21 19:58:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 05:20:46 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 05:51:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155979)
6 years, 7 months ago (2014-05-22 05:51:26 UTC) #7
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 7 months ago (2014-05-27 17:14:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/291843009/40001
6 years, 7 months ago (2014-05-27 17:15:28 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 21:06:54 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 00:52:43 UTC) #11
Message was sent while issue was closed.
Change committed as 273093

Powered by Google App Engine
This is Rietveld 408576698