Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 291843008: [Metrics] Fetch more embedder concepts via MetricsServiceClient. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.cc
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index 8f17097ecde7714ecf617a01eb2e5aca39836635..8a9367e827faadc4699533b9174a84a5c37ed733 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -191,9 +191,7 @@
#include "chrome/browser/metrics/network_metrics_provider.h"
#include "chrome/browser/metrics/omnibox_metrics_provider.h"
#include "chrome/browser/metrics/tracking_synchronizer.h"
-#include "chrome/browser/ui/browser_otr_state.h"
#include "chrome/common/chrome_constants.h"
-#include "chrome/common/crash_keys.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/variations/variations_util.h"
#include "components/metrics/metrics_log_base.h"
@@ -548,7 +546,7 @@ void MetricsService::EnableRecording() {
recording_active_ = true;
state_manager_->ForceClientIdCreation();
- crash_keys::SetClientID(state_manager_->client_id());
+ client_->SetClientID(state_manager_->client_id());
if (!log_manager_.current_log())
OpenNewLog();
@@ -1764,7 +1762,7 @@ bool MetricsService::ShouldLogEvents() {
// We simply don't log events to UMA if there is a single incognito
// session visible. The problem is that we always notify using the orginal
// profile in order to simplify notification processing.
- return !chrome::IsOffTheRecordSessionActive();
+ return !client_->IsOffTheRecordSessionActive();
}
void MetricsService::RecordBooleanPrefValue(const char* path, bool value) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698