Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 291843002: [Win,Linux] New avatar menu: Don't show the "Sign in to Chrome" button if sign-in is not allowed. (Closed)

Created:
6 years, 7 months ago by Marc Treib
Modified:
6 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, noms (inactive)
Visibility:
Public.

Description

New avatar menu: Don't show the "Sign in to Chrome" button if sign-in is not allowed. If the SigninManager won't allow signing in, then showing the button makes no sense. The hotdog menu does much the same thing (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/toolbar/wrench_menu_model.cc&l=583) Mac implementation to follow. BUG=372812, 310640 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272019

Patch Set 1 #

Patch Set 2 : Fix CrOS build. #

Patch Set 3 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Marc Treib
PTAL, or feel free to reassign if you're not the right person to review this. ...
6 years, 7 months ago (2014-05-20 11:10:01 UTC) #1
msw
The profile chooser view isn't shown at all on CrOS, right? If so, LGTM.
6 years, 7 months ago (2014-05-20 17:16:28 UTC) #2
Marc Treib
On 2014/05/20 17:16:28, msw wrote: > The profile chooser view isn't shown at all on ...
6 years, 7 months ago (2014-05-21 07:36:27 UTC) #3
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 7 months ago (2014-05-21 07:36:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/291843002/40001
6 years, 7 months ago (2014-05-21 07:38:26 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 23:41:35 UTC) #6
Message was sent while issue was closed.
Change committed as 272019

Powered by Google App Engine
This is Rietveld 408576698