appengine/config_service/OWNERS - Issue 2918403007: Add OWNERS files

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/config_service/OWNERS

Issue 2918403007: Add OWNERS files (Closed)

Patch Set: add dnj and iannucci to client/OWNERS Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	1 set noparent

1 nodir@chromium.org	2 nodir@chromium.org

	3 vadimsh@chromium.org
	Vadim Sh. 2017/06/08 22:15:39 please remove me from here, I don't know this code please remove me from here, I don't know this code sufficiently well. This will leave you as the only owner (considering 'noparent'), and this is kind of bad. nodir 2017/06/08 22:20:21 How come? you agreed to co-own buildbucket while i Show quoted text On 2017/06/08 22:15:39, Vadim Sh. wrote: > please remove me from here, I don't know this code sufficiently well. How come? you agreed to co-own buildbucket while i am on vacation. Show quoted text > This will leave you as the only owner (considering 'noparent'), and this is kind > of bad. This conversation is not effective. I am tired of it. I will remove set noparent and land it Vadim Sh. 2017/06/08 22:23:56 This is config_service, not buildbucket. Show quoted text On 2017/06/08 22:20:21, nodir wrote: > On 2017/06/08 22:15:39, Vadim Sh. wrote: > > please remove me from here, I don't know this code sufficiently well. > > How come? you agreed to co-own buildbucket while i am on vacation. > This is config_service, not buildbucket. Show quoted text > > This will leave you as the only owner (considering 'noparent'), and this is > kind > > of bad. > > This conversation is not effective. I am tired of it. I will remove set noparent > and land it
OLD	NEW