CrOS Tablet Window management - Split Screen part I

ash/wm/overview/window_grid.h

Index: ash/wm/overview/window_grid.h
diff --git a/ash/wm/overview/window_grid.h b/ash/wm/overview/window_grid.h
index a0352d94aa4eb33af44d92b458b102127f1b3dfa..a9ef356fd0abc050e1d904f4a8579841009614c7 100644
--- a/ash/wm/overview/window_grid.h
+++ b/ash/wm/overview/window_grid.h
@@ -16,6 +16,7 @@
 #include "base/macros.h"
 #include "base/scoped_observer.h"
 #include "ui/aura/window_observer.h"
+#include "ui/gfx/geometry/rect.h"
 
 namespace views {
 class Widget;
@@ -52,7 +53,8 @@ class ASH_EXPORT WindowGrid : public aura::WindowObserver,
  public:
   WindowGrid(aura::Window* root_window,
              const std::vector<aura::Window*>& window_list,
-             WindowSelector* window_selector);
+             WindowSelector* window_selector,
+             const gfx::Rect& bounds_in_screen);
   ~WindowGrid() override;
 
   // Exits overview mode, fading out the |shield_widget_| if necessary.
@@ -88,6 +90,9 @@ class ASH_EXPORT WindowGrid : public aura::WindowObserver,
   // this grid owns.
   bool Contains(const aura::Window* window) const;
 
+  // Remove window selector iten |selector_item| from the grid.

[varkha, 2017/06/21 01:51:53]

nit: How about
// Removes |selector_item| from the grid.
Simpler and the type can be inferred from the method parameter.

[xdai1, 2017/06/22 21:46:33]

Done.

+  void RemoveItem(WindowSelectorItem* selector_item);
+
   // Dims the items whose titles do not contain |pattern| and prevents their
   // selection. The pattern has its accents removed and is converted to
   // lowercase in a l10n sensitive context.
@@ -99,6 +104,9 @@ class ASH_EXPORT WindowGrid : public aura::WindowObserver,
   // opacity, effectively hiding the selector widget.
   void WindowClosing(WindowSelectorItem* window);
 
+  // Set bounds for the window grid and position all windows in the grid.

[varkha, 2017/06/21 01:51:52]

nits:
 Set -> Sets
 position -> positions

[xdai1, 2017/06/22 21:46:33]

Done.

+  void SetTotalBoundsInScreen(const gfx::Rect bounds);

[varkha, 2017/06/21 01:51:53]

nit: Consider SetBoundsAndUpdatePositions(const gfx::Rect& bounds_in_screen)
since "total" qualifier is used in .cc file for just the portion of the screen
that accommodates the window items. This terminology goes back to the UX design
mocks so maybe I am just partial but it is more consistent since you are really
just setting |bounds_| and then calculating a local |total_bounds| variable in
code.
Note const& as well.

[xdai1, 2017/06/22 21:46:33]

Good suggestion. Thanks. Done.

+
   // Returns true if the grid has no more windows.
   bool empty() const { return window_list_.empty(); }
 
@@ -190,6 +198,9 @@ class ASH_EXPORT WindowGrid : public aura::WindowObserver,
   // True only after all windows have been prepared for overview.
   bool prepared_for_overview_;
 
+  // The bound in screen coordinates for the window grid.

[varkha, 2017/06/21 01:51:52]

nit: // This WindowGrid's total bounds in screen coordinates.

[xdai1, 2017/06/22 21:46:33]

Done.

+  gfx::Rect bounds_;
+
   DISALLOW_COPY_AND_ASSIGN(WindowGrid);
 };