Issue 2918393002: [arm64] Fix the GetStackPointer stub to return the C stack pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2918393002: [arm64] Fix the GetStackPointer stub to return the C stack pointer. (Closed)

Created:
3 years, 6 months ago by rmacnak

Modified:
3 years, 6 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[arm64] Fix the GetStackPointer stub to return the C stack pointer. Fixes stack overflow checks when compiled with -fsanitize=safe-stack, and presumably -fsanitize=address as well. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/936cbb2075c15f341f079f62f585458c3d3d104d

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -10 lines)			Patch
M	runtime/vm/native_arguments.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/thread.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 6 months ago (2017-06-05 19:16:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
936cbb2075c15f341f079f62f585458c3d3d104d (presubmit successful).