Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2918373003: Improve annotation of type variables in type inference tests. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve annotation of type variables in type inference tests. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2162b2da9b4ab518c501a27027f4c675b1d7a757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -30 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 1 chunk +23 lines, -24 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_function_of_t_using_the_t.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/void_return_type_subtypes_dynamic.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference/void_return_type_subtypes_dynamic.dart.strong.expect View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-05 17:56:06 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-05 18:27:14 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-05 18:47:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2162b2da9b4ab518c501a27027f4c675b1d7a757 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698