Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2918343002: Move LocalDeclarationVisitor for use by contributors that will be moved to analyzer_plugin (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move LocalDeclarationVisitor for use by contributors that will be moved to analyzer_plugin R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e8a5e404c34b925a308c710acb3fda324a1139c8

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -398 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart View 1 chunk +0 lines, -281 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/test_all.dart View 1 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/test/services/completion/dart/local_declaration_visitor_test.dart View 1 chunk +0 lines, -87 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/dart/analysis/results.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 3 chunks +14 lines, -7 lines 0 comments Download
A + pkg/analyzer_plugin/lib/src/utilities/visitors/local_declaration_visitor.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer_plugin/test/src/utilities/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/visitors/local_declaration_visitor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/visitors/test_all.dart View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Also fixes a typo that was causing some test failures on my machine.
3 years, 6 months ago (2017-06-05 16:50:58 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-05 16:56:02 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-05 17:24:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e8a5e404c34b925a308c710acb3fda324a1139c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698