Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 291833002: [TaskManager] Change ResourceMap to figure ResourceList (Closed)

Created:
6 years, 7 months ago by peria
Modified:
6 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Change the type of values in ResourceMap from ResourceList* to ResourceList. This CL is not an actual fix of the bug (crbug.com/364243), but it avoids those crashes. BUG=364243 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271375

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -25 lines) Patch
M chrome/browser/task_manager/task_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 5 chunks +19 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
peria
Hi Nick, Could you take a look?
6 years, 7 months ago (2014-05-19 08:06:49 UTC) #1
ncarter (slow)
lgtm -- seems correct. But I'm trying to figure out in what sort of circumstance ...
6 years, 7 months ago (2014-05-19 08:53:04 UTC) #2
peria
On 2014/05/19 08:53:04, ncarter wrote: > lgtm -- seems correct. > > But I'm trying ...
6 years, 7 months ago (2014-05-19 08:58:23 UTC) #3
peria
The CQ bit was checked by peria@chromium.org
6 years, 7 months ago (2014-05-19 08:59:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/291833002/20001
6 years, 7 months ago (2014-05-19 08:59:13 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 12:54:54 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 14:12:28 UTC) #7
Message was sent while issue was closed.
Change committed as 271375

Powered by Google App Engine
This is Rietveld 408576698