[abandoned] Remove the destination file after failed copy.

chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h"
 
 #include <sys/statvfs.h>
 
 #include <algorithm>
 #include <utility>
@@ skipping 141 matching lines @@
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   file_manager::EventRouter* event_router =
       GetEventRouterByProfileId(profile_id);
   if (event_router)
     event_router->OnCopyCompleted(
         operation_id,
         source_url.ToGURL(), destination_url.ToGURL(), error);
 }
 
+void OnRemoveAfterFailedCopyCompleted(base::File::Error error) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+  // We just ignore the status.
+  DLOG_IF(WARNING, error != base::File::FILE_OK)
+      << "Failed to remove the destination file after failed copy: " << error;
+}
+
 // Callback invoked upon completion of Copy() (regardless of succeeded or
 // failed).
 void OnCopyCompleted(
     void* profile_id,
+    scoped_refptr<storage::FileSystemContext> file_system_context,
     storage::FileSystemOperationRunner::OperationID* operation_id,
     const FileSystemURL& source_url,
     const FileSystemURL& destination_url,
     base::File::Error error) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 
+  if (error != base::File::FILE_OK) {
+    file_system_context->operation_runner()->Remove(
+        destination_url, false, base::Bind(&OnRemoveAfterFailedCopyCompleted));

[fukino, 2017/06/05 04:20:08]

Is it safe to call NotifyCopyCompletion before Remove operation is done?

+  }
+
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::BindOnce(&NotifyCopyCompletion, profile_id, *operation_id,
                      source_url, destination_url, error));
 }
 
 // Starts the copy operation via FileSystemOperationRunner.
 storage::FileSystemOperationRunner::OperationID StartCopyOnIOThread(
     void* profile_id,
     scoped_refptr<storage::FileSystemContext> file_system_context,
     const FileSystemURL& source_url,
     const FileSystemURL& destination_url) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 
   // Note: |operation_id| is owned by the callback for
   // FileSystemOperationRunner::Copy(). It is always called in the next message
   // loop or later, so at least during this invocation it should alive.
   //
   // TODO(yawano): change ERROR_BEHAVIOR_ABORT to ERROR_BEHAVIOR_SKIP after
   //     error messages of individual operations become appear in the Files app
   //     UI.
   storage::FileSystemOperationRunner::OperationID* operation_id =
       new storage::FileSystemOperationRunner::OperationID;
   *operation_id = file_system_context->operation_runner()->Copy(

[fukino, 2017/06/05 04:20:08]

It might be better to remove incomplete file inside the copy operation in
(native?) file system.

       source_url, destination_url,
       storage::FileSystemOperation::OPTION_PRESERVE_LAST_MODIFIED,
       storage::FileSystemOperation::ERROR_BEHAVIOR_ABORT,
       base::Bind(&OnCopyProgress, profile_id, base::Unretained(operation_id)),
-      base::Bind(&OnCopyCompleted, profile_id, base::Owned(operation_id),
-                 source_url, destination_url));
+      base::Bind(&OnCopyCompleted, profile_id, file_system_context,
+                 base::Owned(operation_id), source_url, destination_url));
   return *operation_id;
 }
 
 void OnCopyCancelled(base::File::Error error) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 
   // We just ignore the status if the copy is actually cancelled or not,
   // because failing cancellation means the operation is not running now.
   DLOG_IF(WARNING, error != base::File::FILE_OK)
       << "Failed to cancel copy: " << error;
@@ skipping 835 matching lines @@
   return true;
 }
 
 void FileManagerPrivateInternalGetDirectorySizeFunction::
     OnDirectorySizeRetrieved(int64_t size) {
   SetResult(base::MakeUnique<base::Value>(static_cast<double>(size)));
   SendResponse(true);
 }
 
 }  // namespace extensions