Issue 2918253002: invariant cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2918253002: invariant cleanup (Closed)

Created:
3 years, 6 months ago by sra1

Modified:
3 years, 6 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

invariant cleanup - remove inariant(), since all calls replaced wif failedAt() - delete unused typedef R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/a146d932e547dc7529184c25665645558d3af492

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -44 lines)			Patch
M	pkg/compiler/lib/src/common.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/diagnostics/invariant.dart	View	2 chunks	+0 lines, -38 lines	0 comments	Download
M	tests/compiler/dart2js/exit_code_test.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

sra1

3 years, 6 months ago (2017-06-06 15:41:38 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a146d932e547dc7529184c25665645558d3af492 (presubmit successful).