Issue 291823009: Refine the UseCounter for Document.charset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291823009: Refine the UseCounter for Document.charset (Closed)

Created:
6 years, 7 months ago by philipj_slow

Modified:
6 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, watchdog-blink-watchlist_google.com, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Refine the UseCounter for Document.charset The DocumentCharset counter is very high, around 4.5%: http://www.chromestatus.com/metrics/feature/timeline/popularity/127 Measure the setter separately, since it doesn't make much sense and getting rid of it would make charset a simple alias for characterSet. Add a separate counter for defaultCharset, which is likely used less. Note that Document.characterSet is the only attribute in the DOM spec: http://dom.spec.whatwg.org/#document Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174738

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -1 line)			Patch
M	Source/core/dom/Document.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/Document.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/UseCounter.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

PTAL. Depends on https://codereview.chromium.org/299443014/ so no try bots until that has landed.

6 years, 7 months ago (2014-05-23 13:01:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/291823009/1

6 years, 7 months ago (2014-05-23 22:41:18 UTC) #4

Message was sent while issue was closed.

Change committed as 174738

Expand Messages | Collapse Messages