Issue 291823005: Restore Title identification.

Issue 291823005: Restore Title identification. (Closed)

Created:
6 years, 7 months ago by Yaron

Modified:
6 years, 7 months ago

Reviewers:
cjhopman

CC:
kuan

Base URL:
https://code.google.com/p/dom-distiller/@master

Visibility:
Public.

More Reviews

Description

Restore Title identification. https://codereview.chromium.org/275493007 broke title identification since we no longer traverse the <HEAD> element causing us to not find the title. Since we're moving away from Boilerpipe's SAX handling, just use document.title directly instead of trying to detect as part of the Sax event stream. BUG=367243 R=cjhopman@chromium.org Committed: 8c95c16

Patch Set 1 : #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : trim title #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+410 lines, -422 lines)			Patch
	M	boilerpipe-core/src/main/de/l3s/boilerpipe/sax/BoilerpipeHTMLContentHandler.java	View	1 2	1 chunk	+409 lines, -422 lines	0 comments	Download
	M	src/com/dom_distiller/client/ContentExtractor.java	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yaron

Patchset 1 includes the intermediate fix. Patchset 2 is just formatting/comment fix (but obscures the ...

6 years, 7 months ago (2014-05-21 21:00:49 UTC) #1

cjhopman

lgtm https://codereview.chromium.org/291823005/diff/50001/boilerpipe-core/src/main/de/l3s/boilerpipe/sax/BoilerpipeHTMLContentHandler.java File boilerpipe-core/src/main/de/l3s/boilerpipe/sax/BoilerpipeHTMLContentHandler.java (right): https://codereview.chromium.org/291823005/diff/50001/boilerpipe-core/src/main/de/l3s/boilerpipe/sax/BoilerpipeHTMLContentHandler.java#newcode52 boilerpipe-core/src/main/de/l3s/boilerpipe/sax/BoilerpipeHTMLContentHandler.java:52: private final String title = null; This looks ...

6 years, 7 months ago (2014-05-21 21:16:02 UTC) #2

Yaron

Committed patchset #3 manually as r8c95c16 (presubmit successful).

6 years, 7 months ago (2014-05-21 21:42:12 UTC) #3

Yaron

6 years, 7 months ago (2014-05-21 22:26:42 UTC) #4

Message was sent while issue was closed.

On 2014/05/21 21:42:12, Yaron wrote:
> Committed patchset #3 manually as r8c95c16 (presubmit successful).

Weird. I used "git cl land" and that pulled in
https://codereview.chromium.org/290993004/ as well :(

Expand Messages | Collapse Messages