Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 291823003: Histogram for FallbackDNSTestResult. (Closed)

Created:
6 years, 7 months ago by zqiu1
Modified:
6 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Histogram for FallbackDNSTestResult. Added a histogram "Network.Shill.Wifi.FallbackDNSTestResult" for tracking the result of the fallback DNS test. The fallback DNS test is performed when portal detection is failed due to DNS failure. BUG=chromium:366301 TEST=Start chrome, and browse to chrome://histograms to make sure this histogram exist after connect to a wifi network without internet access. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zqiu1
6 years, 7 months ago (2014-05-20 20:44:53 UTC) #1
Ilya Sherman
It looks like you have a typo in the bug referenced in the CL description, ...
6 years, 7 months ago (2014-05-21 08:52:22 UTC) #2
zqiu1
On 2014/05/21 08:52:22, Ilya Sherman wrote: > It looks like you have a typo in ...
6 years, 7 months ago (2014-05-21 17:44:39 UTC) #3
zqiu1
The CQ bit was checked by zqiu@chromium.org
6 years, 7 months ago (2014-05-27 22:03:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zqiu@chromium.org/291823003/1
6 years, 7 months ago (2014-05-27 22:05:15 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 01:57:57 UTC) #6
Message was sent while issue was closed.
Change committed as 273110

Powered by Google App Engine
This is Rietveld 408576698