Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5182)

Unified Diff: chrome/browser/chromeos/profiles/profile_helper.h

Issue 2918203002: cros: Fix loading user profile w/o UserSessionManager (Closed)
Patch Set: fix tests, round 2 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/profiles/profile_helper.h
diff --git a/chrome/browser/chromeos/profiles/profile_helper.h b/chrome/browser/chromeos/profiles/profile_helper.h
index f35d965aa729c653e59238458809eba0146799e2..4d99252ccd84e3013ab42f98cb5118e948a42e08 100644
--- a/chrome/browser/chromeos/profiles/profile_helper.h
+++ b/chrome/browser/chromeos/profiles/profile_helper.h
@@ -76,8 +76,13 @@ class ProfileHelper
// knowledge in one place.
static ProfileHelper* Get();
- // Returns Profile instance that corresponds to |user_id_hash|.
- static Profile* GetProfileByUserIdHash(const std::string& user_id_hash);
+ // Loads and returns Profile instance that corresponds to |user_id_hash| for
+ // test. It should not be used in production code because it could loads a
emaxx 2017/06/08 19:43:54 nit: s/loads/load/, s/skips/skip/
xiyuan 2017/06/08 20:30:40 Done.
+ // not-yet-loaded user profile and skips the user profile initialization code
+ // in UserSessionManager.
+ // See http://crbug.com/728683 and http://crbug.com/718734.
+ static Profile* GetProfileByUserIdHashForTest(
+ const std::string& user_id_hash);
// Returns profile path that corresponds to a given |user_id_hash|.
static base::FilePath GetProfilePathByUserIdHash(

Powered by Google App Engine
This is Rietveld 408576698