cros: Fix loading user profile w/o UserSessionManager

chrome/browser/chromeos/profiles/profile_helper.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_PROFILES_PROFILE_HELPER_H_
 #define CHROME_BROWSER_CHROMEOS_PROFILES_PROFILE_HELPER_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 58 matching lines @@
       public user_manager::UserManager::UserSessionStateObserver {
  public:
   ProfileHelper();
   ~ProfileHelper() override;
 
   // Returns ProfileHelper instance. This class is not singleton and is owned
   // by BrowserProcess/BrowserProcessPlatformPart. This method keeps that
   // knowledge in one place.
   static ProfileHelper* Get();
 
-  // Returns Profile instance that corresponds to |user_id_hash|.
-  static Profile* GetProfileByUserIdHash(const std::string& user_id_hash);
+  // Loads and returns Profile instance that corresponds to |user_id_hash| for
+  // test. It should not be used in production code because it could load a
+  // not-yet-loaded user profile and skip the user profile initialization code
+  // in UserSessionManager.
+  // See http://crbug.com/728683 and http://crbug.com/718734.
+  static Profile* GetProfileByUserIdHashForTest(
+      const std::string& user_id_hash);
 
   // Returns profile path that corresponds to a given |user_id_hash|.
   static base::FilePath GetProfilePathByUserIdHash(
       const std::string& user_id_hash);
 
   // Returns the path that corresponds to the sign-in profile.
   static base::FilePath GetSigninProfileDir();
 
   // Returns OffTheRecord profile for use during signing phase.
   static Profile* GetSigninProfile();
@@ skipping 151 matching lines @@
   std::unique_ptr<FileFlusher> profile_flusher_;
 
   base::WeakPtrFactory<ProfileHelper> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileHelper);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_PROFILES_PROFILE_HELPER_H_