chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h - Issue 2918053003: Settings reset prompt: Fetch default settings only when needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h

Issue 2918053003: Settings reset prompt: Fetch default settings only when needed. (Closed)

Patch Set: Addressed Chris's comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/settings_reset_prompt/default_settings_fetcher.h ('k') | chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h

diff --git a/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h b/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h

index 4e3ca5198fa07456439cb4f7f1389e847664e9ae..a277bd03c7b0e82ce4a28ddea82f7d4e9929d57d 100644

--- a/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h

+++ b/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h

@@ -13,6 +13,7 @@

#include "base/time/time.h"

#include "ui/gfx/range/range.h"

+class BrandcodedDefaultSettings;

class Browser;

namespace safe_browsing {

@@ -28,8 +29,9 @@ class SettingsResetPromptController {

public:

// A controller should be created only if |model->ShouldPromptforReset()|

// is true.

- explicit SettingsResetPromptController(

- std::unique_ptr<SettingsResetPromptModel> model);

+ SettingsResetPromptController(

+ std::unique_ptr<SettingsResetPromptModel> model,

+ std::unique_ptr<BrandcodedDefaultSettings> default_settings);

static void ShowSettingsResetPrompt(

Browser* browser,

@@ -65,6 +67,7 @@ class SettingsResetPromptController {

void OnInteractionDone();

std::unique_ptr<SettingsResetPromptModel> model_;

+ std::unique_ptr<BrandcodedDefaultSettings> default_settings_;

base::string16 main_text_;

gfx::Range main_text_url_range_;