chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc - Issue 2918053003: Settings reset prompt: Fetch default settings only when needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc

Issue 2918053003: Settings reset prompt: Fetch default settings only when needed. (Closed)

Patch Set: Nit: Move function definition to match declaration order in header Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model.cc ('K') | « chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_browsertest_win.cc ('k') | chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc

diff --git a/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc b/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc

index 05f1b5cf5f7ad4195afd36b2e393a768785d809f..17f318fa06bc32ceeb5d52394a75be1dfcb65488 100644

--- a/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc

+++ b/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc

@@ -432,7 +432,8 @@ TEST_P(ResetStatesTest, PerformReset) {

.Times(1);

ModelPointer model = CreateModel(reset_urls, std::move(profile_resetter));

- model->PerformReset(base::Bind(&SettingsResetPromptModelTest::OnResetDone,

+ model->PerformReset(base::MakeUnique<BrandcodedDefaultSettings>(),

+ base::Bind(&SettingsResetPromptModelTest::OnResetDone,

base::Unretained(this)));

EXPECT_EQ(reset_callbacks_, 1);

}