Log eventlogs from legacy isolate archive command

client/cmd/isolate/isolate_event_logger.go

Index: client/cmd/isolate/isolate_event_logger.go
diff --git a/client/cmd/isolate/isolate_event_logger.go b/client/cmd/isolate/isolate_event_logger.go
new file mode 100644
index 0000000000000000000000000000000000000000..e6f483b2ecd9e775d02190e26d374ab044958119
--- /dev/null
+++ b/client/cmd/isolate/isolate_event_logger.go
@@ -0,0 +1,100 @@
+// Copyright 2017 The LUCI Authors. All rights reserved.
+// Use of this source code is governed under the Apache License, Version 2.0
+// that can be found in the LICENSE file.
+
+package main
+
+import (
+	"os"
+	"time"
+
+	"golang.org/x/net/context"
+
+	"github.com/golang/protobuf/proto"
+	"github.com/luci/luci-go/common/eventlog"
+	logpb "github.com/luci/luci-go/common/eventlog/proto"
+)
+
+type synclogger interface {

[mithro, 2017/06/02 06:52:55]

Should this be syncLogger ?

[mcgreevy_g, 2017/06/02 07:04:43]

Done.

+	LogSync(ctx context.Context, events ...*eventlog.ChromeInfraLogEvent) error
+	NewLogEvent(ctx context.Context, eventTime eventlog.TypedTime) *eventlog.ChromeInfraLogEvent
+}
+
+// An IsolateEventLogger logs eventlogs which describe an isolate run.

[mithro, 2017/06/02 06:52:55]

This sentence doesn't read quite right. 

[mcgreevy_g, 2017/06/02 07:04:43]

It's hard when "isolate" is both a verb and noun.

Better?

+type IsolateEventLogger struct {
+	client synclogger
+
+	// getEnvironmentValue looks up the value of an environment variable.
+	// Set this to override the default implementation for testing.
+	getEnvironmentValue func(key string) *string
+}
+
+// NewLogger returns an IsolateEventLogger which logs to the specified endpoint.
+func NewLogger(ctx context.Context, endpoint string) *IsolateEventLogger {
+	l := &IsolateEventLogger{}
+	if host := eventlogEndpoint(endpoint); host != "" {
+		l.client = eventlog.NewClient(ctx, host)
+	}
+	return l
+}
+
+// logStats synchronously logs an eventlog which describes an isolate run.
+func (l *IsolateEventLogger) logStats(ctx context.Context, op *logpb.IsolateClientEvent_Operation, start, end time.Time, archiveDetails *logpb.IsolateClientEvent_ArchiveDetails) error {
+	if l.client == nil {
+		return nil
+	}
+	bi := l.getBuildbotInfo()
+	event := l.client.NewLogEvent(ctx, eventlog.Point())
+	event.InfraEvent.IsolateClientEvent = &logpb.IsolateClientEvent{
+		Binary: &logpb.Binary{
+			Name:          proto.String("isolate"),
+			VersionNumber: proto.String(version),
+		},
+		Operation:      op,
+		ArchiveDetails: archiveDetails,
+		Master:         bi.master,
+		Builder:        bi.builder,
+		BuildId:        bi.buildID,
+		Slave:          bi.slave,
+		StartTsUsec:    proto.Int64(int64(start.UnixNano() / 1e3)),
+		EndTsUsec:      proto.Int64(int64(end.UnixNano() / 1e3)),
+	}
+	return l.client.LogSync(ctx, event)
+}
+
+func eventlogEndpoint(endpointFlag string) string {
+	switch endpointFlag {
+	case "test":
+		return eventlog.TestEndpoint
+	case "prod":
+		return eventlog.ProdEndpoint
+	default:
+		return endpointFlag
+	}
+}
+
+// buildbotInfo contains information about the build in which this command was run.
+type buildbotInfo struct {
+	// Variables which are not present in the environment are nil.
+	master, builder, buildID, slave *string
+}
+
+// getBuildbotInfo poulates a buildbotInfo with information from the environment.

[mithro, 2017/06/02 06:52:55]

Buildbot or BuildBot?

[mcgreevy_g, 2017/06/02 07:04:43]

Buildbot; it's one word -- I checked.

+func (l *IsolateEventLogger) getBuildbotInfo() *buildbotInfo {
+	return &buildbotInfo{
+		master:  l.getEnvValue("BUILDBOT_MASTERNAME"),
+		builder: l.getEnvValue("BUILDBOT_BUILDERNAME"),
+		buildID: l.getEnvValue("BUILDBOT_BUILDNUMBER"),
+		slave:   l.getEnvValue("BUILDBOT_SLAVENAME"),
+	}
+}
+
+func (l *IsolateEventLogger) getEnvValue(key string) *string {
+	if l.getEnvironmentValue != nil {
+		return l.getEnvironmentValue(key)
+	}
+	if val, ok := os.LookupEnv(key); ok {
+		return &val
+	}
+	return nil
+}