Reorganize the CreateIsolateAndSetupHelper code to make it more readable and facilitate further cha…

Reorganize the CreateIsolateAndSetupHelper code to make it more readable and facilitate further changes to start the service isolate from a kernel IR file.

BUG=
R=rmacnak@google.com, sivachandra@google.com

Committed: https://github.com/dart-lang/sdk/commit/4b8cc6b205c1a72566d83c94ec265e3c9b68358a

[siva, 2017-06-02 01:30:08]

asiva@google.com changed reviewers:
+ rmacnak@google.com, sivachandra@google.com

[rmacnak, 2017-06-02 17:03:45]

lgtm

https://codereview.chromium.org/2918033002/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2918033002/diff/1/runtime/bin/main.cc#newcode...
runtime/bin/main.cc:1005: // app snapshot if the script_uri points to one.
This code is assuming it isn't an app snapshot.

[siva, 2017-06-02 17:38:57]

https://codereview.chromium.org/2918033002/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2918033002/diff/1/runtime/bin/main.cc#newcode...
runtime/bin/main.cc:1005: // app snapshot if the script_uri points to one.
On 2017/06/02 17:03:44, rmacnak wrote:
> This code is assuming it isn't an app snapshot.

Fixed the comment.

[sivachandra, 2017-06-02 17:39:47]

lgtm

[siva, 2017-06-02 17:43:38]

Description was changed from

==========
Reorganize the CreateIsolateAndSetupHelper code to make it more readable and
facilitate further changes to start the service isolate from a kernel IR file.

BUG=
==========

to

==========
Reorganize the CreateIsolateAndSetupHelper code to make it more readable and
facilitate further changes to start the service isolate from a kernel IR file.

BUG=
R=rmacnak@google.com, sivachandra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4b8cc6b205c1a72566d83c94ec265e3c9b68358a
==========

[siva, 2017-06-02 17:43:39]

Committed patchset #2 (id:20001) manually as
4b8cc6b205c1a72566d83c94ec265e3c9b68358a (presubmit successful).