Issue 291803004: Fix build error for windows for Dashing CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291803004: Fix build error for windows for Dashing CL (Closed)

Created:
6 years, 7 months ago by egdaniel

Modified:
6 years, 7 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Fix build error for windows for Dashing CL NOTREECHECKS=True NOTRY=True TBR=bsalomon@google.com BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14776

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/gpu/effects/GrDashingEffect.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/291803004/1

6 years, 7 months ago (2014-05-19 14:43:40 UTC) #2

f(malita)

6 years, 7 months ago (2014-05-19 14:56:18 UTC) #4

Message was sent while issue was closed.

On 2014/05/19 14:43:49, I haz the power (commit-bot) wrote:
> Change committed as 14776

Looks like the GM is still failing to build:
http://108.170.220.76:10117/builders/Build-Win8-VS2012-x86-Debug/builds/2592/...

Expand Messages | Collapse Messages