Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 2918023002: Set cc::Display visibility to false when going to the background. (Closed)

Created:
3 years, 6 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 6 months ago
Reviewers:
boliu
CC:
chromium-reviews, darin-cc_chromium.org, jam, Maria, ssid
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set cc::Display visibility to false when going to the background. This visibility notification path was unhooked at some point during the refactoring to split into layer/display compositor in the last year or two. It was rehooked but only for Aura in https://codereview.chromium.org/2238693002, leaving Android with visibility permanently true on the display compositor. BUG=728885

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 2 chunks +5 lines, -1 line 1 comment Download

Messages

Total messages: 6 (3 generated)
aelias_OOO_until_Jul13
Hi Bo, PTAL.
3 years, 6 months ago (2017-06-02 00:27:26 UTC) #2
boliu
https://codereview.chromium.org/2918023002/diff/1/content/browser/renderer_host/compositor_impl_android.cc File content/browser/renderer_host/compositor_impl_android.cc (right): https://codereview.chromium.org/2918023002/diff/1/content/browser/renderer_host/compositor_impl_android.cc#newcode568 content/browser/renderer_host/compositor_impl_android.cc:568: display_.reset(); we reset the display a few lines below, ...
3 years, 6 months ago (2017-06-02 00:30:35 UTC) #5
aelias_OOO_until_Jul13
3 years, 6 months ago (2017-06-02 01:13:57 UTC) #6
Yeah, OK, it doesn't do anything extra compared to the destructors except call
DiscardBackbufferCHROMIUM, which is otherwise released anyway, so closing this.

Powered by Google App Engine
This is Rietveld 408576698