components/autofill/content/renderer/password_form_conversion_utils.h - Issue 2917933002: [PasswordGeneration] Improve change/confirm password field detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.h

Issue 2917933002: [PasswordGeneration] Improve change/confirm password field detection. (Closed)

Patch Set: Address more comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_form_conversion_utils.cc » ('j') | components/autofill/content/renderer/password_form_conversion_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils.h

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.h b/components/autofill/content/renderer/password_form_conversion_utils.h

index 0cebba2f265020f30360f9406c6e742da33beff8..3e4f4029051150d3e8afb3ae078ef55e4c1e24de 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.h

+++ b/components/autofill/content/renderer/password_form_conversion_utils.h

@@ -9,6 +9,7 @@

#include <memory>

#include <vector>

+#include "base/strings/string_piece.h"

#include "components/autofill/core/common/password_form.h"

#include "components/autofill/core/common/password_form_field_prediction_map.h"

#include "third_party/WebKit/public/platform/WebString.h"

@@ -62,7 +63,7 @@ std::unique_ptr<PasswordForm> CreatePasswordFormFromUnownedInputElements(

// Checks in a case-insensitive way if the autocomplete attribute for the given

// |element| is present and has the specified |value_in_lowercase|.

bool HasAutocompleteAttributeValue(const blink::WebInputElement& element,

- const char* value_in_lowercase);

+ base::StringPiece value_in_lowercase);

// Checks in a case-insensitive way if credit card autocomplete attributes for

// the given |element| are present.