chrome/renderer/autofill/password_generation_agent_browsertest.cc - Issue 2917933002: [PasswordGeneration] Improve change/confirm password field detection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_generation_agent_browsertest.cc

Issue 2917933002: [PasswordGeneration] Improve change/confirm password field detection. (Closed)

Patch Set: Clean up and fix test. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/autofill/password_generation_agent_browsertest.cc

diff --git a/chrome/renderer/autofill/password_generation_agent_browsertest.cc b/chrome/renderer/autofill/password_generation_agent_browsertest.cc

index ecfa0783c933e2837e511b536339f2eb12a7966f..aa581e101bcb5266c31a1ce610a591dc38acc6f7 100644

--- a/chrome/renderer/autofill/password_generation_agent_browsertest.cc

+++ b/chrome/renderer/autofill/password_generation_agent_browsertest.cc

@@ -619,7 +619,7 @@ TEST_F(PasswordGenerationAgentTest, AutocompleteAttributesTest) {

SetNotBlacklistedMessage(password_generation_,

kNewPasswordAutocompleteAttributeFormHTML);

- ExpectGenerationAvailable("first_password", false);

+ ExpectGenerationAvailable("first_password", true);

}

TEST_F(PasswordGenerationAgentTest, ChangePasswordFormDetectionTest) {