[PasswordGeneration] Improve change/confirm password field detection.

chrome/renderer/autofill/password_generation_agent_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
@@ skipping 590 matching lines @@
 
 TEST_F(PasswordGenerationAgentTest, AutocompleteAttributesTest) {
   // Verify that autocomplete attributes can override Autofill to enable
   // generation
   LoadHTMLWithUserGesture(kBothAutocompleteAttributesFormHTML);
   SetNotBlacklistedMessage(password_generation_,
                            kBothAutocompleteAttributesFormHTML);
 
   ExpectGenerationAvailable("first_password", true);
 
   // Only setting one of the two attributes doesn't trigger generation.

[dvadym, 2017/06/08 14:56:59]

This comment doesn't true anymore

[pkalinnikov, 2017/06/09 08:02:42]

Fixed.

   LoadHTMLWithUserGesture(kUsernameAutocompleteAttributeFormHTML);
   SetNotBlacklistedMessage(password_generation_,
                            kUsernameAutocompleteAttributeFormHTML);
 
   ExpectGenerationAvailable("first_password", false);
 
   LoadHTMLWithUserGesture(kNewPasswordAutocompleteAttributeFormHTML);
   SetNotBlacklistedMessage(password_generation_,
                            kNewPasswordAutocompleteAttributeFormHTML);
 
-  ExpectGenerationAvailable("first_password", false);
+  ExpectGenerationAvailable("first_password", true);

[dvadym, 2017/06/08 14:56:59]

Could you please add here the checking form without username with new-password
autocomplete attributes

[pkalinnikov, 2017/06/09 08:02:42]

Done.

 }
 
 TEST_F(PasswordGenerationAgentTest, ChangePasswordFormDetectionTest) {
   // Verify that generation is shown on correct field after message receiving.
   LoadHTMLWithUserGesture(kPasswordChangeFormHTML);
   SetNotBlacklistedMessage(password_generation_, kPasswordChangeFormHTML);
   ExpectGenerationAvailable("password", false);
   ExpectGenerationAvailable("newpassword", false);
   ExpectGenerationAvailable("confirmpassword", false);
 
@@ skipping 173 matching lines @@
   ExpectGenerationAvailable(kGenerationElementId, true);
   password_generation_->GeneratedPasswordAccepted(base::ASCIIToUTF16("pwd"));
   ExecuteJavaScriptForTests(
       "document.getElementById('first_password').value = '';");
   FocusField(kGenerationElementId);
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(fake_driver_.called_password_no_longer_generated());
 }
 
 }  // namespace autofill