components/security_state_strings.grdp - Issue 2917873004: Implement 'Not secure' warning for non-secure pages in Incognito mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_state_strings.grdp

Issue 2917873004: Implement 'Not secure' warning for non-secure pages in Incognito mode (Closed)

Patch Set: Remove obsolete includes Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/security_state/core/security_state_unittest.cc ('k') | ios/chrome/browser/ssl/ios_security_state_tab_helper.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_state_strings.grdp

diff --git a/components/security_state_strings.grdp b/components/security_state_strings.grdp

index 1982f9112ba372d9d63b80b8aea67fbcdc35f09a..482b6c9df78ad16072f87663a7ddebf10cbb6e34 100644

--- a/components/security_state_strings.grdp

+++ b/components/security_state_strings.grdp

@@ -7,6 +7,12 @@

This page includes a password or credit card input over HTTP. A warning has been added to the URL bar.

</message>

+ <message name="IDS_INCOGNITO_NONSECURE" desc="Summary phrase for a security problem where the site is non-secure (HTTP) and the user is browsing Incognito." translateable="false">

+ Non-secure page loaded in incognito mode

+ </message>

+ <message name="IDS_INCOGNITO_NONSECURE_DESCRIPTION" desc="Description of a security problem where the site is non-secure (HTTP) and the user is browsing Incognito, which results in an omnibox warning." translateable="false">

+ This page was loaded non-securely in an incognito window. A warning has been added to the URL bar.

+ </message>

This page is dangerous (flagged by Google Safe Browsing).

</message>