Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: components/security_state/core/security_state.h

Issue 2917873004: Implement 'Not secure' warning for non-secure pages in Incognito mode (Closed)
Patch Set: Ensure sensitive fields trigger warnings outside of Incognito Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/core/security_state.h
diff --git a/components/security_state/core/security_state.h b/components/security_state/core/security_state.h
index 4d1ec3f90ce375ebc0be84fb98e6c0d4406cc319..0307f1b60a4499b3f8efbfe877d90228cb5cdb33 100644
--- a/components/security_state/core/security_state.h
+++ b/components/security_state/core/security_state.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_SECURITY_STATE_SECURITY_STATE_H_
-#define COMPONENTS_SECURITY_STATE_SECURITY_STATE_H_
+#ifndef COMPONENTS_SECURITY_STATE_CORE_SECURITY_STATE_H_
elawrence 2017/06/07 21:05:05 git cl lint insisted.
+#define COMPONENTS_SECURITY_STATE_CORE_SECURITY_STATE_H_
#include <stdint.h>
#include <memory>
@@ -141,6 +141,9 @@ struct SecurityInfo {
// True if the server's certificate does not contain a
// subjectAltName extension with a domain name or IP address.
bool cert_missing_subject_alt_name;
+ // True if |IsHttpWarningForIncognitoEnabled| and the page was displayed in a
+ // non-secure Incognito context.
+ bool is_incognito;
};
// Contains the security state relevant to computing the SecurityInfo
@@ -181,6 +184,9 @@ struct VisibleSecurityState {
bool displayed_password_field_on_http;
// True if the page was an HTTP page that displayed a credit card field.
bool displayed_credit_card_field_on_http;
+ // True if |IsHttpWarningForIncognitoEnabled| and the page was displayed in a
+ // non-secure Incognito context.
+ bool is_incognito;
};
// These security levels describe the treatment given to pages that
@@ -209,6 +215,10 @@ void GetSecurityInfo(
// |kHttpFormWarningFeature| feature.
bool IsHttpWarningInFormEnabled();
+// Returns true if the MarkHttpAs setting indicates that a warning
+// should be shown for HTTP pages loaded while in Incognito mode.
+bool IsHttpWarningForIncognitoEnabled();
+
} // namespace security_state
-#endif // COMPONENTS_SECURITY_STATE_SECURITY_STATE_H_
+#endif // COMPONENTS_SECURITY_STATE_CORE_SECURITY_STATE_H_

Powered by Google App Engine
This is Rietveld 408576698