Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Side by Side Diff: chrome/browser/ssl/security_state_tab_helper.h

Issue 2917873004: Implement 'Not secure' warning for non-secure pages in Incognito mode (Closed)
Patch Set: Ensure sensitive fields trigger warnings outside of Incognito Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SSL_SECURITY_STATE_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_SSL_SECURITY_STATE_TAB_HELPER_H_
6 #define CHROME_BROWSER_SSL_SECURITY_STATE_TAB_HELPER_H_ 6 #define CHROME_BROWSER_SSL_SECURITY_STATE_TAB_HELPER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 private: 44 private:
45 explicit SecurityStateTabHelper(content::WebContents* web_contents); 45 explicit SecurityStateTabHelper(content::WebContents* web_contents);
46 friend class content::WebContentsUserData<SecurityStateTabHelper>; 46 friend class content::WebContentsUserData<SecurityStateTabHelper>;
47 47
48 bool UsedPolicyInstalledCertificate() const; 48 bool UsedPolicyInstalledCertificate() const;
49 security_state::MaliciousContentStatus GetMaliciousContentStatus() const; 49 security_state::MaliciousContentStatus GetMaliciousContentStatus() const;
50 std::unique_ptr<security_state::VisibleSecurityState> 50 std::unique_ptr<security_state::VisibleSecurityState>
51 GetVisibleSecurityState() const; 51 GetVisibleSecurityState() const;
52 52
53 // True if a console message has been logged about an omnibox warning that 53 // True if a console message has been logged about an omnibox warning shown
54 // will be shown in future versions of Chrome for insecure HTTP pages. This 54 // when insecure HTTP pages are loaded in Incognito mode. This message should
55 // message should only be logged once per main-frame navigation. 55 // only be logged once per main-frame navigation.
56 bool logged_incognito_warning_on_current_navigation_;
57 // True if a console message has been logged about an omnibox warning shown
58 // when sensitive input fields are shown on insecure HTTP pages. This message
59 // should only be logged once per main-frame navigation.
56 bool logged_http_warning_on_current_navigation_; 60 bool logged_http_warning_on_current_navigation_;
57 61
58 // The time that a console or omnibox warning was shown for insecure 62 // The time that a console or omnibox warning was shown for insecure
59 // HTTP pages that contain password or credit card fields. This is set 63 // HTTP pages that contain password or credit card fields. This is set
60 // at most once per main-frame navigation (the first time that an HTTP 64 // at most once per main-frame navigation (the first time that an HTTP
61 // warning triggers on that navigation) and is used for UMA 65 // warning triggers on that navigation) and is used for UMA
62 // histogramming. 66 // histogramming.
63 base::Time time_of_http_warning_on_current_navigation_; 67 base::Time time_of_http_warning_on_current_navigation_;
64 68
65 DISALLOW_COPY_AND_ASSIGN(SecurityStateTabHelper); 69 DISALLOW_COPY_AND_ASSIGN(SecurityStateTabHelper);
66 }; 70 };
67 71
68 #endif // CHROME_BROWSER_SSL_SECURITY_STATE_TAB_HELPER_H_ 72 #endif // CHROME_BROWSER_SSL_SECURITY_STATE_TAB_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698