Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2917863003: Various infrastructure changes. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -29 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 8 chunks +18 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 3 chunks +14 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 1 6 chunks +74 lines, -10 lines 0 comments Download
M runtime/lib/errors_patch.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 6 months ago (2017-06-01 12:30:30 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2917863003/diff/1/pkg/front_end/lib/src/fasta/target_implementation.dart File pkg/front_end/lib/src/fasta/target_implementation.dart (right): https://codereview.chromium.org/2917863003/diff/1/pkg/front_end/lib/src/fasta/target_implementation.dart#newcode94 pkg/front_end/lib/src/fasta/target_implementation.dart:94: /// constructor is expected to accept a no ...
3 years, 6 months ago (2017-06-01 12:36:50 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/2917863003/diff/1/pkg/front_end/lib/src/fasta/target_implementation.dart File pkg/front_end/lib/src/fasta/target_implementation.dart (right): https://codereview.chromium.org/2917863003/diff/1/pkg/front_end/lib/src/fasta/target_implementation.dart#newcode94 pkg/front_end/lib/src/fasta/target_implementation.dart:94: /// constructor is expected to accept ...
3 years, 6 months ago (2017-06-01 13:07:49 UTC) #4
ahe
3 years, 6 months ago (2017-06-01 13:16:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5b94cfe33a71bc69e1ced2f0b4e4c511322218fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698