Compute correct return type for factory methods.

Compute correct return type for factory methods.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/984b13052d16fabcfe71fd5b47d037c537ff65f8

[ahe, 2017-06-01 11:30:03]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, paulberry@google.com

[Johnni Winther, 2017-06-01 11:56:46]

lgtm

[ahe, 2017-06-01 12:02:05]

Description was changed from

==========
Compute correct return type for factory methods.
==========

to

==========
Compute correct return type for factory methods.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/984b13052d16fabcfe71fd5b47d037c537ff65f8
==========

[ahe, 2017-06-01 12:02:07]

Committed patchset #2 (id:20001) manually as
984b13052d16fabcfe71fd5b47d037c537ff65f8 (presubmit successful).

[Paul Berry, 2017-06-01 12:57:00]

lgtm, however I'm surprised because my version of this CL
(https://codereview.chromium.org/2916533003/) updated some expectation files
than yours didn't.  Specifically, these ones:

pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting_factory_to_factory.dart.direct.expect
pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting_factory_to_factory.dart.outline.expect
pkg/front_end/testcases/rasta/class_hierarchy.dart.outline.expect
pkg/front_end/testcases/rasta/issue_000002.dart.direct.expect
pkg/front_end/testcases/redirecting_constructor.dart.direct.expect
pkg/front_end/testcases/redirecting_constructor.dart.outline.expect
pkg/front_end/testcases/redirecting_factory.dart.outline.expect

Any idea why your CL didn't need to update these files?

[Paul Berry, 2017-06-01 13:01:29]

On 2017/06/01 12:57:00, Paul Berry wrote:
> lgtm, however I'm surprised because my version of this CL
> (https://codereview.chromium.org/2916533003/) updated some expectation files
> than yours didn't.  Specifically, these ones:
> 
>
pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting_factory_to_factory.dart.direct.expect
>
pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting_factory_to_factory.dart.outline.expect
> pkg/front_end/testcases/rasta/class_hierarchy.dart.outline.expect
> pkg/front_end/testcases/rasta/issue_000002.dart.direct.expect
> pkg/front_end/testcases/redirecting_constructor.dart.direct.expect
> pkg/front_end/testcases/redirecting_constructor.dart.outline.expect
> pkg/front_end/testcases/redirecting_factory.dart.outline.expect
> 
> Any idea why your CL didn't need to update these files?

Never mind, I just noticed that the changes happened in
https://codereview.chromium.org/2921623002/.

[ahe, 2017-06-01 13:02:50]

On 2017/06/01 12:57:00, Paul Berry wrote:
> lgtm, however I'm surprised because my version of this CL
> (https://codereview.chromium.org/2916533003/) updated some expectation files
> than yours didn't.  Specifically, these ones:
> 
>
pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting_factory_to_factory.dart.direct.expect
>
pkg/front_end/testcases/inference/constructors_infer_from_arguments_redirecting_factory_to_factory.dart.outline.expect
> pkg/front_end/testcases/rasta/class_hierarchy.dart.outline.expect
> pkg/front_end/testcases/rasta/issue_000002.dart.direct.expect
> pkg/front_end/testcases/redirecting_constructor.dart.direct.expect
> pkg/front_end/testcases/redirecting_constructor.dart.outline.expect
> pkg/front_end/testcases/redirecting_factory.dart.outline.expect
> 
> Any idea why your CL didn't need to update these files?

I landed those already in a different CL.

Why did I land them in a different CL? Because I started it a bit earlier just
to reduce the differences between my dev branch and master. See CL 2921623002.