Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 291773002: Mojo cpp bindings: fix |num_fields| in struct header of *Params_Data. (Closed)

Created:
6 years, 7 months ago by yzshen1
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo cpp bindings: fix |num_fields| in struct header of *Params_Data. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/tools/bindings/generators/cpp_templates/params_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yzshen1
Hi, Matt. Would you please take a look? Thanks!
6 years, 7 months ago (2014-05-18 23:18:56 UTC) #1
darin (slow to review)
LGTM
6 years, 7 months ago (2014-05-19 01:32:21 UTC) #2
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 7 months ago (2014-05-19 05:19:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/291773002/1
6 years, 7 months ago (2014-05-19 05:20:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 06:53:33 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 08:13:45 UTC) #6
Message was sent while issue was closed.
Change committed as 271352

Powered by Google App Engine
This is Rietveld 408576698