Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: ui/events/blink/event_with_callback.cc

Issue 2917713002: Teach input_handler_proxy about once callbacks. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/blink/event_with_callback.h ('k') | ui/events/blink/input_handler_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/blink/event_with_callback.cc
diff --git a/ui/events/blink/event_with_callback.cc b/ui/events/blink/event_with_callback.cc
index 8fc9a88e45668a5515af900c5501c65ab2e4161f..39793f4e67e8b6752f34341ba07e05f5e3ef5ee0 100644
--- a/ui/events/blink/event_with_callback.cc
+++ b/ui/events/blink/event_with_callback.cc
@@ -18,12 +18,12 @@ EventWithCallback::EventWithCallback(
WebScopedInputEvent event,
const LatencyInfo& latency,
base::TimeTicks timestamp_now,
- const InputHandlerProxy::EventDispositionCallback& callback)
+ InputHandlerProxy::EventDispositionCallback callback)
: event_(WebInputEventTraits::Clone(*event)),
latency_(latency),
creation_timestamp_(timestamp_now),
last_coalesced_timestamp_(timestamp_now) {
- original_events_.emplace_back(std::move(event), callback);
+ original_events_.emplace_back(std::move(event), std::move(callback));
}
EventWithCallback::EventWithCallback(
@@ -78,15 +78,16 @@ void EventWithCallback::RunCallbacks(
did_overscroll_params_copy =
base::MakeUnique<DidOverscrollParams>(*did_overscroll_params);
}
- original_event.callback_.Run(disposition, std::move(original_event.event_),
- latency, std::move(did_overscroll_params));
+ std::move(original_event.callback_)
+ .Run(disposition, std::move(original_event.event_), latency,
+ std::move(did_overscroll_params));
}
}
EventWithCallback::OriginalEventWithCallback::OriginalEventWithCallback(
WebScopedInputEvent event,
- const InputHandlerProxy::EventDispositionCallback& callback)
- : event_(std::move(event)), callback_(callback) {}
+ InputHandlerProxy::EventDispositionCallback callback)
+ : event_(std::move(event)), callback_(std::move(callback)) {}
EventWithCallback::OriginalEventWithCallback::~OriginalEventWithCallback() {}
« no previous file with comments | « ui/events/blink/event_with_callback.h ('k') | ui/events/blink/input_handler_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698