chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2917703004: [Android] Wrap all share parameters into the ShareParams class

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2917703004: [Android] Wrap all share parameters into the ShareParams class (Closed)

Patch Set: Update based on Ted and Yusuf's comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index ef3b1c1bf9ae0e8d273efea9cb4e1aa121ef807c..16e0dbdd9b5a4e86e1c5d3f2080580bcf55f2442 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -114,6 +114,7 @@ import org.chromium.chrome.browser.printing.TabPrinter;

import org.chromium.chrome.browser.share.OptionalShareTargetsManager;

import org.chromium.chrome.browser.share.ShareActivity;

import org.chromium.chrome.browser.share.ShareHelper;

+import org.chromium.chrome.browser.share.ShareParams;

import org.chromium.chrome.browser.snackbar.BottomContainer;

import org.chromium.chrome.browser.snackbar.DataReductionPromoSnackbarController;

import org.chromium.chrome.browser.snackbar.DataUseSnackbarController;

@@ -1292,12 +1293,16 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

final Uri blockingUri = (isIncognito || webContents == null)

? null

: ChromeFileProvider.generateUriAndBlockAccess(mainActivity);

+ boolean saveLastUsed = shareDirectly ? false : true;

Yusuf 2017/06/02 20:07:46 !

ltian 2017/06/02 23:44:39 Done.

+ ShareParams.Builder builder =

+ new ShareParams.Builder(mainActivity, currentTab.getTitle(), currentTab.getUrl())

+ .setShareDirectly(shareDirectly)

+ .setSaveLastUsed(saveLastUsed)

Yusuf 2017/06/02 20:07:46 how about !shareDirectly here? But the question s

ltian 2017/06/02 23:44:39 For offline discussion, we will merge them into on

+ .setScreenshotUri(blockingUri);

if (canShareOfflinePage) {

- OfflinePageUtils.shareOfflinePage(shareDirectly, true, mainActivity, null,

- blockingUri, null, currentTab);

+ OfflinePageUtils.shareOfflinePage(builder, currentTab);

} else {

- ShareHelper.share(shareDirectly, true, mainActivity, currentTab.getTitle(), null,

- currentTab.getUrl(), null, blockingUri, null);

+ ShareHelper.share(builder.build());

if (shareDirectly) {

RecordUserAction.record("MobileMenuDirectShare");

} else {