Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2917703004: [Android] Wrap all share parameters into the ShareParams class (Closed)
Patch Set: Update based on Matt's comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 289dad8178c97d3332aba8c2c1dae7a747c6ef29..dc9f26091a02eb444e45c5059d169d8c61d4fc80 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -114,6 +114,7 @@ import org.chromium.chrome.browser.printing.TabPrinter;
import org.chromium.chrome.browser.share.OptionalShareTargetsManager;
import org.chromium.chrome.browser.share.ShareActivity;
import org.chromium.chrome.browser.share.ShareHelper;
+import org.chromium.chrome.browser.share.ShareParams;
import org.chromium.chrome.browser.snackbar.BottomContainer;
import org.chromium.chrome.browser.snackbar.DataReductionPromoSnackbarController;
import org.chromium.chrome.browser.snackbar.DataUseSnackbarController;
@@ -1296,12 +1297,15 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
final Uri blockingUri = (isIncognito || webContents == null)
? null
: ChromeFileProvider.generateUriAndBlockAccess(mainActivity);
+ ShareParams.Builder builder =
+ new ShareParams.Builder(mainActivity, currentTab.getTitle(), currentTab.getUrl())
+ .setShareDirectly(shareDirectly)
+ .setSaveLastUsed(!shareDirectly)
+ .setScreenshotUri(blockingUri);
if (canShareOfflinePage) {
- OfflinePageUtils.shareOfflinePage(shareDirectly, true, mainActivity, null,
- blockingUri, null, currentTab);
+ OfflinePageUtils.shareOfflinePage(builder, currentTab);
} else {
- ShareHelper.share(shareDirectly, true, mainActivity, currentTab.getTitle(), null,
- currentTab.getUrl(), null, blockingUri, null);
+ ShareHelper.share(builder.build());
if (shareDirectly) {
RecordUserAction.record("MobileMenuDirectShare");
} else {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698