chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java - Issue 2917703004: [Android] Wrap all share parameters into the ShareParams class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java

Issue 2917703004: [Android] Wrap all share parameters into the ShareParams class (Closed)

Patch Set: Improve code. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/share/ShareParams.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/WebShareTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java

index 0c7fc6294eb41aac4662e4ac7e9820c07d61f7af..50c3a6fa8ef043cc2c8c9d87d00893a692d70788 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java

@@ -43,8 +43,9 @@ public class ShareUrlTest {

mUiThreadTestRule.runOnUiThread(new Runnable() {

@Override

public void run() {

- Intent intent =

- ShareHelper.getShareIntent(new Activity(), "", "", sharedUrl, null, null);

+ ShareParams params =

+ new ShareParams.Builder(new Activity(), "", sharedUrl).setText("").build();

+ Intent intent = ShareHelper.getShareLinkIntent(params);

Assert.assertTrue(intent.hasExtra(Intent.EXTRA_TEXT));

String url = intent.getStringExtra(Intent.EXTRA_TEXT);

Assert.assertEquals(originalUrl, url);