chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java - Issue 2917703004: [Android] Wrap all share parameters into the ShareParams class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

Issue 2917703004: [Android] Wrap all share parameters into the ShareParams class (Closed)

Patch Set: Improve code. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/share/ShareParams.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/share/ShareParams.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

index 9c411d3a09c1ddc9ab47eb9799c17bb1af04e7ba..e68c768dc1453f3e48f9b45f3baa40ecb9b96eba 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

@@ -10,6 +10,7 @@ import android.support.annotation.Nullable;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.browser.share.ShareHelper;

+import org.chromium.chrome.browser.share.ShareParams;

import org.chromium.content_public.browser.WebContents;

import org.chromium.mojo.system.MojoException;

import org.chromium.ui.base.WindowAndroid;

@@ -76,7 +77,11 @@ public class ShareServiceImpl implements ShareService {

}

};

- ShareHelper.share(false, false, mActivity, title, text, url.url, null, null, innerCallback);

+ ShareParams params = new ShareParams.Builder(mActivity, title, url.url)

+ .setText(text)

+ .setCallback(innerCallback)

+ .build();

+ ShareHelper.share(params);

}

@Nullable