[Android] Wrap all share parameters into the ShareParams class

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 96 matching lines @@
 import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomizations;
 import org.chromium.chrome.browser.physicalweb.PhysicalWebShareActivity;
 import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
 import org.chromium.chrome.browser.preferences.PrefServiceBridge;
 import org.chromium.chrome.browser.preferences.PreferencesLauncher;
 import org.chromium.chrome.browser.printing.PrintShareActivity;
 import org.chromium.chrome.browser.printing.TabPrinter;
 import org.chromium.chrome.browser.share.OptionalShareTargetsManager;
 import org.chromium.chrome.browser.share.ShareActivity;
 import org.chromium.chrome.browser.share.ShareHelper;
+import org.chromium.chrome.browser.share.ShareParams;
 import org.chromium.chrome.browser.snackbar.BottomContainer;
 import org.chromium.chrome.browser.snackbar.DataReductionPromoSnackbarController;
 import org.chromium.chrome.browser.snackbar.DataUseSnackbarController;
 import org.chromium.chrome.browser.snackbar.SnackbarManager;
 import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable;
 import org.chromium.chrome.browser.sync.ProfileSyncService;
 import org.chromium.chrome.browser.sync.SyncController;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tabmodel.AsyncTabParamsManager;
 import org.chromium.chrome.browser.tabmodel.EmptyTabModel;
@@ skipping 1158 matching lines @@
 
         RecordHistogram.recordBooleanHistogram(
                 "OfflinePages.SharedPageWasOffline", OfflinePageUtils.isOfflinePage(currentTab));
         boolean canShareOfflinePage = OfflinePageBridge.isPageSharingEnabled();
 
         // Share an empty blockingUri in place of screenshot file. The file ready notification is
         // sent by onScreenshotReady call below when the file is written.
         final Uri blockingUri = (isIncognito || webContents == null)
                 ? null
                 : ChromeFileProvider.generateUriAndBlockAccess(mainActivity);
+        boolean saveLastUsed = shareDirectly ? false : true;

[Yusuf, 2017/06/02 20:07:46]

!

[ltian, 2017/06/02 23:44:39]

Done.

+        ShareParams.Builder builder =
+                new ShareParams.Builder(mainActivity, currentTab.getTitle(), currentTab.getUrl())
+                        .setShareDirectly(shareDirectly)
+                        .setSaveLastUsed(saveLastUsed)

[Yusuf, 2017/06/02 20:07:46]

how about !shareDirectly here?

But the question still stands: Do we need these both? Are they always negative
of each other? If yes, then we should have a more enveloping name and keep just
one imo.

[ltian, 2017/06/02 23:44:39]

For offline discussion, we will merge them into one parameter.

+                        .setScreenshotUri(blockingUri);
         if (canShareOfflinePage) {
-            OfflinePageUtils.shareOfflinePage(shareDirectly, true, mainActivity, null,
-                    blockingUri, null, currentTab);
+            OfflinePageUtils.shareOfflinePage(builder, currentTab);
         } else {
-            ShareHelper.share(shareDirectly, true, mainActivity, currentTab.getTitle(), null,
-                    currentTab.getUrl(), null, blockingUri, null);
+            ShareHelper.share(builder.build());
             if (shareDirectly) {
                 RecordUserAction.record("MobileMenuDirectShare");
             } else {
                 RecordUserAction.record("MobileMenuShare");
             }
         }
 
         if (blockingUri == null) return;
 
         // Start screenshot capture and notify the provider when it is ready.
@@ skipping 906 matching lines @@
         return false;
     }
 
     /**
      * @return the reference pool for this activity.
      */
     public DiscardableReferencePool getReferencePool() {
         return mReferencePool;
     }
 }