Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2917663002: Clean up instrumentation of invocation targets. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up instrumentation of invocation targets. We should be instrumenting at same the place we set the value of `interfaceTarget`. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2b561fe657cd615248f1a204447c4add11a8c325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-05-31 12:22:57 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-05-31 16:14:46 UTC) #3
Paul Berry
3 years, 6 months ago (2017-05-31 16:42:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b561fe657cd615248f1a204447c4add11a8c325 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698