Reland "Move a good set of gfx unit tests into gfx_unittests target."

ui/gfx/test/run_all_unittests.cc

Index: ui/gfx/test/run_all_unittests.cc
diff --git a/ui/gfx/test/run_all_unittests.cc b/ui/gfx/test/run_all_unittests.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6e50e200589c28de5cb0dce1750b31d1311e9659
--- /dev/null
+++ b/ui/gfx/test/run_all_unittests.cc
@@ -0,0 +1,52 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/basictypes.h"
+#include "base/bind.h"
+#include "base/compiler_specific.h"
+#include "base/path_service.h"
+#include "base/test/launcher/unit_test_launcher.h"
+#include "base/test/test_suite.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/base/ui_base_paths.h"
+
+namespace {
+
+class GfxTestSuite : public base::TestSuite {
+ public:
+  GfxTestSuite(int argc, char** argv) : base::TestSuite(argc, argv) {}
+
+ protected:
+  virtual void Initialize() OVERRIDE {
+    base::TestSuite::Initialize();
+    ui::RegisterPathProvider();
+
+    base::FilePath pak_dir;
+    PathService::Get(base::DIR_MODULE, &pak_dir);
+
+    base::FilePath pak_file;
+    pak_file = pak_dir.Append(FILE_PATH_LITERAL("ui_test.pak"));
+
+    ui::ResourceBundle::InitSharedInstanceWithPakPath(pak_file);

[sadrul, 2014/05/21 18:49:10]

Does the gfx tests actually use anything from the resource-bundle?

[tfarina, 2014/05/21 19:03:35]

Yes. Both font_unittests.cc and text_elider_unittests.cc end up calling things
that require ResourceBundle initialization.

[sadrul, 2014/05/21 19:10:21]

Ah, I see. That seems unfortunate. Perhaps we could clean these up.

[tfarina, 2014/05/21 19:28:54]

For further reference the error (without this call) was:

[5967:5967:0521/162544:1047643224706:FATAL:font_list.cc(115)] Check failed:
!(g_default_font_description == NULL). SetDefaultFontDescription has not been
called.

And the list of tests that crashes without this call is:
27 tests crashed:
    FontTest.AvgWidths
    ImageSkiaTest.ArbitraryScaleFactor
    ImageSkiaTest.ArbitraryScaleFactorWithMissingResource
    ImageSkiaTest.BackedBySameObjectAs
    ImageSkiaTest.DynamicSource
    ImageSkiaTest.EmptyOnThreadTest
    ImageSkiaTest.FixedSource
    ImageSkiaTest.GetBitmap
    ImageSkiaTest.GetBitmapFromEmpty
    ImageSkiaTest.ManyRepsPerScaleFactor
    ImageSkiaTest.SourceOnThreadTest
    ImageSkiaTest.StaticOnThreadTest
    ImageSkiaTest.Unscaled
    ImageSkiaTest.UnscaledImageForArbitraryScaleFactor
    TextEliderTest.ElideEmail
    TextEliderTest.ElideEmailMoreSpace
    TextEliderTest.ElideRectangleText
    TextEliderTest.ElideRectangleTextCheckLineWidth
    TextEliderTest.ElideRectangleTextLongWords
    TextEliderTest.ElideRectangleTextPunctuation
    TextEliderTest.ElideTextEllipsis
    TextEliderTest.ElideTextEllipsisFront
    TextEliderTest.ElideTextLongStrings
    TextEliderTest.ElideTextSurrogatePairs
    TextEliderTest.ElideTextTruncate
    TextEliderTest.TestFilenameEliding
    TextUtilsTest.GetStringWidth

Hence this call to InitSharedInstanceWithPakPath() be extremely important.

+  }
+
+  virtual void Shutdown() OVERRIDE {
+    ui::ResourceBundle::CleanupSharedInstance();
+    base::TestSuite::Shutdown();
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(GfxTestSuite);
+};
+
+}  // namespace
+
+int main(int argc, char** argv) {
+  GfxTestSuite test_suite(argc, argv);
+
+  return base::LaunchUnitTests(
+      argc,
+      argv,
+      base::Bind(&GfxTestSuite::Run, base::Unretained(&test_suite)));
+}