Fix an npe in context_manager.dart.

Fix an npe in context_manager.dart.

BUG=

Committed: https://github.com/dart-lang/sdk/commit/24b0d1489f4b8904d09c65b6d12874f829a5e4c6

[devoncarew, 2017-05-30 21:29:38]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com

[devoncarew, 2017-05-30 21:29:39]

TBR

[devoncarew, 2017-05-30 21:29:40]

TBR

[devoncarew, 2017-05-30 21:30:01]

Description was changed from

==========
Fix an npe in context_manager.dart.

BUG=
==========

to

==========
Fix an npe in context_manager.dart.

BUG=

Committed:
https://github.com/dart-lang/sdk/commit/24b0d1489f4b8904d09c65b6d12874f829a5e4c6
==========

[devoncarew, 2017-05-30 21:30:02]

Committed patchset #1 (id:1) manually as
24b0d1489f4b8904d09c65b6d12874f829a5e4c6 (presubmit successful).

[Brian Wilkerson, 2017-05-30 21:39:48]

lgtm

https://codereview.chromium.org/2917453002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/2917453002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/context_manager.dart:1047: contextRoot:
info?.analysisDriver?.contextRoot);
It would be good to understand why the info is null, because I wouldn't have
expected it to be null at this point. (For example, a quick look indicates that
we might have a path that isn't being analyzed, in which case we probably should
catch it earlier.)

[devoncarew, 2017-05-30 23:16:12]

> pkg/analysis_server/lib/src/context_manager.dart:1047: contextRoot:
> info?.analysisDriver?.contextRoot);
> It would be good to understand why the info is null, because I wouldn't have
> expected it to be null at this point. (For example, a quick look indicates
that
> we might have a path that isn't being analyzed, in which case we probably
should
> catch it earlier.)

It's likely that this was an overuse of null checks - I'll remove the null check
on info and re-run the tests.

[Brian Wilkerson, 2017-05-30 23:53:54]

> It's likely that this was an overuse of null checks - I'll remove the null
check
> on info and re-run the tests.

If that's the case, then it's probably a test that needs to be converted to use
the new driver.