Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: tools/perf/benchmarks/media.py

Issue 2917423003: [Perf] Filter memory metrics in media benchmarks (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/media.py
diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py
index a985c7500bff211fa2ff8fa9d6c68c83e39c5545..f2d02c4856316bcba59486ed15dd5d4236573fae 100644
--- a/tools/perf/benchmarks/media.py
+++ b/tools/perf/benchmarks/media.py
@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import re
+
from core import perf_benchmark
from telemetry import benchmark
@@ -16,6 +18,12 @@ from measurements import media
import page_sets
+# See tr.v.Numeric.getSummarizedScalarNumericsWithNames()
+# https://github.com/catapult-project/catapult/blob/master/tracing/tracing/value/numeric.html#L323
+_IGNORED_STATS_RE = re.compile(
+ r'(?<!dump)(?<!process)_(std|count|max|min|sum|pct_\d{4}(_\d+)?)$')
+
+
class _MSEMeasurement(legacy_page_test.LegacyPageTest):
def __init__(self):
@@ -116,6 +124,12 @@ class MediaToughVideoCasesTBMv2(_MediaTBMv2Benchmark):
def Name(cls):
return 'media.tough_video_cases_tbmv2'
+ @classmethod
+ def ValueCanBeAddedPredicate(cls, value, is_first_result):
+ # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
+ # is able to cope with the data load generated by TBMv2 metrics.
+ return not _IGNORED_STATS_RE.search(value.name)
+
@benchmark.Owner(emails=['johnchen@chromium.org', 'crouleau@chromium.org'],
component='Internals>Media')
@@ -149,6 +163,12 @@ class MediaAndroidToughVideoCasesTBMv2(_MediaTBMv2Benchmark):
['--ignore-autoplay-restrictions',
'--disable-gesture-requirement-for-media-playback'])
+ @classmethod
+ def ValueCanBeAddedPredicate(cls, value, is_first_result):
+ # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
+ # is able to cope with the data load generated by TBMv2 metrics.
+ return not _IGNORED_STATS_RE.search(value.name)
+
@benchmark.Disabled('all') # crbug/676345
@benchmark.Owner(emails=['crouleau@chromium.org', 'videostack-eng@google.com'],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698