Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: components/payments/core/journey_logger.h

Issue 2917343003: Merge-60 [Payments] Move the SelectedPaymentMethod metric to native. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/payments/core/journey_logger.h
diff --git a/components/payments/core/journey_logger.h b/components/payments/core/journey_logger.h
index 7521127c45ec737a7250f1acf19a2a86ecbc6363..edb6eb18318b16ef6b883c72da0c817f75f31039 100644
--- a/components/payments/core/journey_logger.h
+++ b/components/payments/core/journey_logger.h
@@ -165,6 +165,9 @@ class JourneyLogger {
// Records that an event occurred.
void SetEventOccurred(Event event);
+ // Records the payment method that was used to complete the Payment Request.
+ void SetSelectedPaymentMethod(SelectedPaymentMethod payment_method);
+
// Records that the Payment Request was completed successfully, and starts the
// logging of all the journey metrics.
void SetCompleted();
@@ -216,6 +219,9 @@ class JourneyLogger {
// were reached.
void RecordCheckoutFlowMetrics();
+ // Records the metric about the selected payment method.
+ void RecordPaymentMethodMetric();
+
// Records the histograms for all the sections that were requested by the
// merchant.
void RecordSectionSpecificStats(CompletionStatus completion_status);
@@ -246,6 +252,9 @@ class JourneyLogger {
// Accumulates the many events that have happened during the Payment Request.
int events_;
+ // To keep track of the selected payment method.
+ SelectedPaymentMethod payment_method_ = SELECTED_PAYMENT_METHOD_MAX;
+
const GURL url_;
// Not owned, will outlive this object.
« no previous file with comments | « chrome/browser/payments/android/journey_logger_android.cc ('k') | components/payments/core/journey_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698