Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5120)

Unified Diff: chrome/common/favicon/favicon_url_parser_unittest.cc

Issue 291733004: Reduce the use of ui::ScaleFactor in webui/favicon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/favicon/favicon_url_parser.cc ('k') | ui/base/webui/web_ui_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/favicon/favicon_url_parser_unittest.cc
diff --git a/chrome/common/favicon/favicon_url_parser_unittest.cc b/chrome/common/favicon/favicon_url_parser_unittest.cc
index 1ccd9ed1eb278710b321b6f87e6a28d0eee80b14..0e47a48a02e222055cb7665c8107b7436230adfa 100644
--- a/chrome/common/favicon/favicon_url_parser_unittest.cc
+++ b/chrome/common/favicon/favicon_url_parser_unittest.cc
@@ -58,7 +58,7 @@ TEST_F(FaviconUrlParserTest, ParsingSizeParam) {
EXPECT_FALSE(parsed.is_icon_url);
EXPECT_EQ(url, parsed.url);
EXPECT_EQ(32, parsed.size_in_dip);
- EXPECT_EQ(ui::SCALE_FACTOR_100P, parsed.scale_factor);
+ EXPECT_EQ(1.0f, parsed.scale_factor);
// Test parsing current 'size' parameter format.
const std::string path3 = "size/32@1.4x/" + url;
@@ -66,7 +66,7 @@ TEST_F(FaviconUrlParserTest, ParsingSizeParam) {
EXPECT_FALSE(parsed.is_icon_url);
EXPECT_EQ(url, parsed.url);
EXPECT_EQ(32, parsed.size_in_dip);
- EXPECT_EQ(ui::SCALE_FACTOR_140P, parsed.scale_factor);
+ EXPECT_EQ(1.4f, parsed.scale_factor);
// Test that we pick the ui::ScaleFactor which is closest to the passed in
// scale factor.
@@ -75,7 +75,7 @@ TEST_F(FaviconUrlParserTest, ParsingSizeParam) {
EXPECT_FALSE(parsed.is_icon_url);
EXPECT_EQ(url, parsed.url);
EXPECT_EQ(16, parsed.size_in_dip);
- EXPECT_EQ(ui::SCALE_FACTOR_140P, parsed.scale_factor);
+ EXPECT_EQ(1.41f, parsed.scale_factor);
// Invalid cases.
const std::string path5 = "size/" + url;
@@ -91,7 +91,7 @@ TEST_F(FaviconUrlParserTest, ParsingSizeParam) {
EXPECT_FALSE(parsed.is_icon_url);
EXPECT_EQ(path8, parsed.url);
EXPECT_EQ(16, parsed.size_in_dip);
- EXPECT_EQ(ui::SCALE_FACTOR_100P, parsed.scale_factor);
+ EXPECT_EQ(1.0f, parsed.scale_factor);
}
// Test parsing path with the 'largest' parameter.
@@ -155,7 +155,7 @@ TEST_F(FaviconUrlParserTest, ParsingSizeParamAndUrlModifier) {
EXPECT_FALSE(parsed.is_icon_url);
EXPECT_EQ("https://www.google.ca/", parsed.url);
EXPECT_EQ(32, parsed.size_in_dip);
- EXPECT_EQ(ui::SCALE_FACTOR_140P, parsed.scale_factor);
+ EXPECT_EQ(1.4f, parsed.scale_factor);
const std::string path14 =
"largest/iconurl/http://www.google.com/favicon.ico";
« no previous file with comments | « chrome/common/favicon/favicon_url_parser.cc ('k') | ui/base/webui/web_ui_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698