Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: chrome/browser/ui/webui/fileicon_source.h

Issue 291733004: Reduce the use of ui::ScaleFactor in webui/favicon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_FILEICON_SOURCE_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_FILEICON_SOURCE_H_
6 #define CHROME_BROWSER_UI_WEBUI_FILEICON_SOURCE_H_ 6 #define CHROME_BROWSER_UI_WEBUI_FILEICON_SOURCE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "base/task/cancelable_task_tracker.h" 11 #include "base/task/cancelable_task_tracker.h"
12 #include "chrome/browser/icon_manager.h" 12 #include "chrome/browser/icon_manager.h"
13 #include "content/public/browser/url_data_source.h" 13 #include "content/public/browser/url_data_source.h"
14 #include "ui/base/layout.h"
15 14
16 namespace gfx { 15 namespace gfx {
17 class Image; 16 class Image;
18 } 17 }
19 18
20 // FileIconSource is the gateway between network-level chrome: 19 // FileIconSource is the gateway between network-level chrome:
21 // requests for favicons and the history backend that serves these. 20 // requests for favicons and the history backend that serves these.
22 class FileIconSource : public content::URLDataSource { 21 class FileIconSource : public content::URLDataSource {
23 public: 22 public:
24 explicit FileIconSource(); 23 explicit FileIconSource();
25 24
26 // content::URLDataSource implementation. 25 // content::URLDataSource implementation.
27 virtual std::string GetSource() const OVERRIDE; 26 virtual std::string GetSource() const OVERRIDE;
28 virtual void StartDataRequest( 27 virtual void StartDataRequest(
29 const std::string& path, 28 const std::string& path,
30 int render_process_id, 29 int render_process_id,
31 int render_frame_id, 30 int render_frame_id,
32 const content::URLDataSource::GotDataCallback& callback) OVERRIDE; 31 const content::URLDataSource::GotDataCallback& callback) OVERRIDE;
33 virtual std::string GetMimeType(const std::string&) const OVERRIDE; 32 virtual std::string GetMimeType(const std::string&) const OVERRIDE;
34 33
35 protected: 34 protected:
36 virtual ~FileIconSource(); 35 virtual ~FileIconSource();
37 36
38 // Once the |path| and |icon_size| has been determined from the request, this 37 // Once the |path| and |icon_size| has been determined from the request, this
39 // function is called to perform the actual fetch. Declared as virtual for 38 // function is called to perform the actual fetch. Declared as virtual for
40 // testing. 39 // testing.
41 virtual void FetchFileIcon( 40 virtual void FetchFileIcon(
42 const base::FilePath& path, 41 const base::FilePath& path,
43 ui::ScaleFactor scale_factor, 42 float scale_factor,
44 IconLoader::IconSize icon_size, 43 IconLoader::IconSize icon_size,
45 const content::URLDataSource::GotDataCallback& callback); 44 const content::URLDataSource::GotDataCallback& callback);
46 45
47 private: 46 private:
48 // Contains the necessary information for completing an icon fetch request. 47 // Contains the necessary information for completing an icon fetch request.
49 struct IconRequestDetails { 48 struct IconRequestDetails {
50 IconRequestDetails(); 49 IconRequestDetails();
51 ~IconRequestDetails(); 50 ~IconRequestDetails();
52 51
53 // The callback to run with the response. 52 // The callback to run with the response.
54 content::URLDataSource::GotDataCallback callback; 53 content::URLDataSource::GotDataCallback callback;
55 54
56 // The requested scale factor to respond with. 55 // The requested scale factor to respond with.
57 ui::ScaleFactor scale_factor; 56 float scale_factor;
58 }; 57 };
59 58
60 // Called when favicon data is available from the history backend. 59 // Called when favicon data is available from the history backend.
61 void OnFileIconDataAvailable(const IconRequestDetails& details, 60 void OnFileIconDataAvailable(const IconRequestDetails& details,
62 gfx::Image* icon); 61 gfx::Image* icon);
63 62
64 // Tracks tasks requesting file icons. 63 // Tracks tasks requesting file icons.
65 base::CancelableTaskTracker cancelable_task_tracker_; 64 base::CancelableTaskTracker cancelable_task_tracker_;
66 65
67 DISALLOW_COPY_AND_ASSIGN(FileIconSource); 66 DISALLOW_COPY_AND_ASSIGN(FileIconSource);
68 }; 67 };
69 #endif // CHROME_BROWSER_UI_WEBUI_FILEICON_SOURCE_H_ 68 #endif // CHROME_BROWSER_UI_WEBUI_FILEICON_SOURCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698