Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/ForAwaitOf.golden

Issue 2917263002: Move generator-close on exception from the generator function to the GeneratorResume builtin. (Closed)
Patch Set: Add the builtins to the uncaught exception prediction list Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/builtins/builtins-generator-gen.cc ('K') | « src/parsing/preparser.h ('k') | test/cctest/interpreter/bytecode_expectations/ForOfLoop.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/ForAwaitOf.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/ForAwaitOf.golden b/test/cctest/interpreter/bytecode_expectations/ForAwaitOf.golden
index a8522862f848505e40df9ca875bbe04b135d5333..d376f0e4c6eed13ec5f4aaefb428af1a1d440876 100644
--- a/test/cctest/interpreter/bytecode_expectations/ForAwaitOf.golden
+++ b/test/cctest/interpreter/bytecode_expectations/ForAwaitOf.golden
@@ -16,7 +16,7 @@ snippet: "
"
frame size: 27
parameter count: 1
-bytecode array length: 739
+bytecode array length: 712
bytecodes: [
B(Mov), R(new_target), R(11),
B(Ldar), R(new_target),
@@ -94,17 +94,13 @@ bytecodes: [
B(Star), R(24),
B(LdaZero),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(28),
+ B(JumpIfTrue), U8(19),
B(LdaSmi), I8(2),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(19),
- B(LdaTrue),
- B(Star), R(26),
- B(Mov), R(23), R(25),
- B(InvokeIntrinsic), U8(Runtime::k_CreateIterResultObject), R(25), U8(2),
- B(Star), R(19),
+ B(JumpIfTrue), U8(10),
B(LdaZero),
B(Star), R(18),
+ B(Mov), R(23), R(19),
B(Jump), U8(101),
B(Ldar), R(23),
/* 40 E> */ B(ReThrow),
@@ -124,7 +120,7 @@ bytecodes: [
B(Mov), R(3), R(0),
B(LdaZero),
B(Star), R(6),
- B(JumpLoop), U8(153), I8(0),
+ B(JumpLoop), U8(144), I8(0),
B(Jump), U8(40),
B(Star), R(22),
B(Ldar), R(closure),
@@ -154,15 +150,15 @@ bytecodes: [
B(Star), R(20),
B(LdaZero),
B(TestEqualStrict), R(6), U8(21),
- B(JumpIfTrueConstant), U8(16),
+ B(JumpIfTrue), U8(253),
B(LdaNamedProperty), R(4), U8(12), U8(22),
B(Star), R(9),
B(TestUndetectable),
B(JumpIfFalse), U8(4),
- B(JumpConstant), U8(15),
+ B(Jump), U8(242),
B(LdaSmi), I8(1),
B(TestEqualStrict), R(6), U8(25),
- B(JumpIfFalse), U8(145),
+ B(JumpIfFalse), U8(136),
B(Ldar), R(9),
B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4),
@@ -198,18 +194,14 @@ bytecodes: [
B(Star), R(24),
B(LdaZero),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(28),
+ B(JumpIfTrue), U8(19),
B(LdaSmi), I8(2),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(19),
- B(LdaTrue),
- B(Star), R(26),
- B(Mov), R(23), R(25),
- B(InvokeIntrinsic), U8(Runtime::k_CreateIterResultObject), R(25), U8(2),
- B(Star), R(15),
+ B(JumpIfTrue), U8(10),
B(LdaZero),
B(Star), R(14),
- B(Jump), U8(237),
+ B(Mov), R(23), R(15),
+ B(Jump), U8(228),
B(Ldar), R(23),
B(ReThrow),
B(Ldar), R(23),
@@ -223,7 +215,7 @@ bytecodes: [
B(Ldar), R(21),
B(PushContext), R(22),
B(PopContext), R(22),
- B(Jump), U8(110),
+ B(Jump), U8(101),
B(LdaUndefined),
B(Star), R(22),
B(Mov), R(9), R(24),
@@ -248,17 +240,13 @@ bytecodes: [
B(Star), R(23),
B(LdaZero),
B(TestEqualStrictNoFeedback), R(23),
- B(JumpIfTrue), U8(28),
+ B(JumpIfTrue), U8(19),
B(LdaSmi), I8(2),
B(TestEqualStrictNoFeedback), R(23),
- B(JumpIfTrue), U8(19),
- B(LdaTrue),
- B(Star), R(25),
- B(Mov), R(22), R(24),
- B(InvokeIntrinsic), U8(Runtime::k_CreateIterResultObject), R(24), U8(2),
- B(Star), R(15),
+ B(JumpIfTrue), U8(10),
B(LdaZero),
B(Star), R(14),
+ B(Mov), R(22), R(15),
B(Jump), U8(121),
B(Ldar), R(22),
B(ReThrow),
@@ -270,7 +258,7 @@ bytecodes: [
B(Ldar), R(20),
B(SetPendingMessage),
B(Ldar), R(18),
- B(SwitchOnSmiNoFeedback), U8(17), U8(2), I8(0),
+ B(SwitchOnSmiNoFeedback), U8(15), U8(2), I8(0),
B(Jump), U8(13),
B(LdaZero),
B(Star), R(14),
@@ -291,7 +279,7 @@ bytecodes: [
B(Jump), U8(45),
B(Star), R(18),
B(Ldar), R(closure),
- B(CreateCatchContext), R(18), U8(10), U8(19),
+ B(CreateCatchContext), R(18), U8(10), U8(17),
B(Star), R(17),
B(LdaTheHole),
B(SetPendingMessage),
@@ -326,7 +314,7 @@ bytecodes: [
B(Ldar), R(16),
B(SetPendingMessage),
B(Ldar), R(14),
- B(SwitchOnSmiNoFeedback), U8(20), U8(2), I8(0),
+ B(SwitchOnSmiNoFeedback), U8(18), U8(2), I8(0),
B(Jump), U8(8),
B(Ldar), R(15),
/* 57 S> */ B(Return),
@@ -337,8 +325,8 @@ bytecodes: [
]
constant pool: [
Smi [102],
- Smi [406],
- Smi [522],
+ Smi [397],
+ Smi [504],
TUPLE2_TYPE,
SYMBOL_TYPE,
SYMBOL_TYPE,
@@ -351,8 +339,6 @@ constant pool: [
ONE_BYTE_INTERNALIZED_STRING_TYPE ["return"],
ONE_BYTE_INTERNALIZED_STRING_TYPE [""],
FIXED_ARRAY_TYPE,
- Smi [260],
- Smi [271],
Smi [6],
Smi [14],
FIXED_ARRAY_TYPE,
@@ -360,11 +346,11 @@ constant pool: [
Smi [9],
]
handlers: [
- [62, 694, 700],
- [65, 649, 651],
- [71, 315, 321],
- [74, 275, 277],
- [382, 476, 478],
+ [62, 667, 673],
+ [65, 622, 624],
+ [71, 306, 312],
+ [74, 266, 268],
+ [373, 458, 460],
]
---
@@ -376,7 +362,7 @@ snippet: "
"
frame size: 27
parameter count: 1
-bytecode array length: 767
+bytecode array length: 740
bytecodes: [
B(Mov), R(new_target), R(11),
B(Ldar), R(new_target),
@@ -454,17 +440,13 @@ bytecodes: [
B(Star), R(24),
B(LdaZero),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(28),
+ B(JumpIfTrue), U8(19),
B(LdaSmi), I8(2),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(19),
- B(LdaTrue),
- B(Star), R(26),
- B(Mov), R(23), R(25),
- B(InvokeIntrinsic), U8(Runtime::k_CreateIterResultObject), R(25), U8(2),
- B(Star), R(19),
+ B(JumpIfTrue), U8(10),
B(LdaZero),
B(Star), R(18),
+ B(Mov), R(23), R(19),
B(Jump), U8(104),
B(Ldar), R(23),
/* 40 E> */ B(ReThrow),
@@ -515,15 +497,15 @@ bytecodes: [
B(Star), R(20),
B(LdaZero),
B(TestEqualStrict), R(6), U8(21),
- B(JumpIfTrueConstant), U8(16),
+ B(JumpIfTrue), U8(253),
B(LdaNamedProperty), R(4), U8(12), U8(22),
B(Star), R(9),
B(TestUndetectable),
B(JumpIfFalse), U8(4),
- B(JumpConstant), U8(15),
+ B(Jump), U8(242),
B(LdaSmi), I8(1),
B(TestEqualStrict), R(6), U8(25),
- B(JumpIfFalse), U8(145),
+ B(JumpIfFalse), U8(136),
B(Ldar), R(9),
B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4),
@@ -559,18 +541,14 @@ bytecodes: [
B(Star), R(24),
B(LdaZero),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(28),
+ B(JumpIfTrue), U8(19),
B(LdaSmi), I8(2),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(19),
- B(LdaTrue),
- B(Star), R(26),
- B(Mov), R(23), R(25),
- B(InvokeIntrinsic), U8(Runtime::k_CreateIterResultObject), R(25), U8(2),
- B(Star), R(15),
+ B(JumpIfTrue), U8(10),
B(LdaZero),
B(Star), R(14),
- B(Jump), U8(246),
+ B(Mov), R(23), R(15),
+ B(Jump), U8(237),
B(Ldar), R(23),
B(ReThrow),
B(Ldar), R(23),
@@ -584,7 +562,7 @@ bytecodes: [
B(Ldar), R(21),
B(PushContext), R(22),
B(PopContext), R(22),
- B(Jump), U8(110),
+ B(Jump), U8(101),
B(LdaUndefined),
B(Star), R(22),
B(Mov), R(9), R(24),
@@ -609,17 +587,13 @@ bytecodes: [
B(Star), R(23),
B(LdaZero),
B(TestEqualStrictNoFeedback), R(23),
- B(JumpIfTrue), U8(28),
+ B(JumpIfTrue), U8(19),
B(LdaSmi), I8(2),
B(TestEqualStrictNoFeedback), R(23),
- B(JumpIfTrue), U8(19),
- B(LdaTrue),
- B(Star), R(25),
- B(Mov), R(22), R(24),
- B(InvokeIntrinsic), U8(Runtime::k_CreateIterResultObject), R(24), U8(2),
- B(Star), R(15),
+ B(JumpIfTrue), U8(10),
B(LdaZero),
B(Star), R(14),
+ B(Mov), R(22), R(15),
B(Jump), U8(130),
B(Ldar), R(22),
B(ReThrow),
@@ -631,7 +605,7 @@ bytecodes: [
B(Ldar), R(20),
B(SetPendingMessage),
B(Ldar), R(18),
- B(SwitchOnSmiNoFeedback), U8(17), U8(3), I8(0),
+ B(SwitchOnSmiNoFeedback), U8(15), U8(3), I8(0),
B(Jump), U8(22),
B(LdaZero),
B(Star), R(14),
@@ -656,7 +630,7 @@ bytecodes: [
B(Jump), U8(45),
B(Star), R(18),
B(Ldar), R(closure),
- B(CreateCatchContext), R(18), U8(10), U8(20),
+ B(CreateCatchContext), R(18), U8(10), U8(18),
B(Star), R(17),
B(LdaTheHole),
B(SetPendingMessage),
@@ -691,7 +665,7 @@ bytecodes: [
B(Ldar), R(16),
B(SetPendingMessage),
B(Ldar), R(14),
- B(SwitchOnSmiNoFeedback), U8(21), U8(3), I8(0),
+ B(SwitchOnSmiNoFeedback), U8(19), U8(3), I8(0),
B(Jump), U8(24),
B(Ldar), R(15),
/* 68 S> */ B(Return),
@@ -709,8 +683,8 @@ bytecodes: [
]
constant pool: [
Smi [102],
- Smi [409],
- Smi [525],
+ Smi [400],
+ Smi [507],
TUPLE2_TYPE,
SYMBOL_TYPE,
SYMBOL_TYPE,
@@ -723,8 +697,6 @@ constant pool: [
ONE_BYTE_INTERNALIZED_STRING_TYPE ["return"],
ONE_BYTE_INTERNALIZED_STRING_TYPE [""],
FIXED_ARRAY_TYPE,
- Smi [260],
- Smi [271],
Smi [6],
Smi [14],
Smi [23],
@@ -734,11 +706,11 @@ constant pool: [
Smi [25],
]
handlers: [
- [62, 706, 712],
- [65, 661, 663],
- [71, 318, 324],
- [74, 278, 280],
- [385, 479, 481],
+ [62, 679, 685],
+ [65, 634, 636],
+ [71, 309, 315],
+ [74, 269, 271],
+ [376, 461, 463],
]
---
@@ -753,7 +725,7 @@ snippet: "
"
frame size: 27
parameter count: 1
-bytecode array length: 757
+bytecode array length: 730
bytecodes: [
B(Mov), R(new_target), R(11),
B(Ldar), R(new_target),
@@ -831,17 +803,13 @@ bytecodes: [
B(Star), R(24),
B(LdaZero),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(28),
+ B(JumpIfTrue), U8(19),
B(LdaSmi), I8(2),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(19),
- B(LdaTrue),
- B(Star), R(26),
- B(Mov), R(23), R(25),
- B(InvokeIntrinsic), U8(Runtime::k_CreateIterResultObject), R(25), U8(2),
- B(Star), R(19),
+ B(JumpIfTrue), U8(10),
B(LdaZero),
B(Star), R(18),
+ B(Mov), R(23), R(19),
B(Jump), U8(119),
B(Ldar), R(23),
/* 40 E> */ B(ReThrow),
@@ -869,7 +837,7 @@ bytecodes: [
/* 103 S> */ B(Jump), U8(8),
B(LdaZero),
B(Star), R(6),
- B(JumpLoop), U8(171), I8(0),
+ B(JumpLoop), U8(162), I8(0),
B(Jump), U8(40),
B(Star), R(22),
B(Ldar), R(closure),
@@ -899,15 +867,15 @@ bytecodes: [
B(Star), R(20),
B(LdaZero),
B(TestEqualStrict), R(6), U8(23),
- B(JumpIfTrueConstant), U8(16),
+ B(JumpIfTrue), U8(253),
B(LdaNamedProperty), R(4), U8(12), U8(24),
B(Star), R(9),
B(TestUndetectable),
B(JumpIfFalse), U8(4),
- B(JumpConstant), U8(15),
+ B(Jump), U8(242),
B(LdaSmi), I8(1),
B(TestEqualStrict), R(6), U8(27),
- B(JumpIfFalse), U8(145),
+ B(JumpIfFalse), U8(136),
B(Ldar), R(9),
B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4),
@@ -943,18 +911,14 @@ bytecodes: [
B(Star), R(24),
B(LdaZero),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(28),
+ B(JumpIfTrue), U8(19),
B(LdaSmi), I8(2),
B(TestEqualStrictNoFeedback), R(24),
- B(JumpIfTrue), U8(19),
- B(LdaTrue),
- B(Star), R(26),
- B(Mov), R(23), R(25),
- B(InvokeIntrinsic), U8(Runtime::k_CreateIterResultObject), R(25), U8(2),
- B(Star), R(15),
+ B(JumpIfTrue), U8(10),
B(LdaZero),
B(Star), R(14),
- B(Jump), U8(237),
+ B(Mov), R(23), R(15),
+ B(Jump), U8(228),
B(Ldar), R(23),
B(ReThrow),
B(Ldar), R(23),
@@ -968,7 +932,7 @@ bytecodes: [
B(Ldar), R(21),
B(PushContext), R(22),
B(PopContext), R(22),
- B(Jump), U8(110),
+ B(Jump), U8(101),
B(LdaUndefined),
B(Star), R(22),
B(Mov), R(9), R(24),
@@ -993,17 +957,13 @@ bytecodes: [
B(Star), R(23),
B(LdaZero),
B(TestEqualStrictNoFeedback), R(23),
- B(JumpIfTrue), U8(28),
+ B(JumpIfTrue), U8(19),
B(LdaSmi), I8(2),
B(TestEqualStrictNoFeedback), R(23),
- B(JumpIfTrue), U8(19),
- B(LdaTrue),
- B(Star), R(25),
- B(Mov), R(22), R(24),
- B(InvokeIntrinsic), U8(Runtime::k_CreateIterResultObject), R(24), U8(2),
- B(Star), R(15),
+ B(JumpIfTrue), U8(10),
B(LdaZero),
B(Star), R(14),
+ B(Mov), R(22), R(15),
B(Jump), U8(121),
B(Ldar), R(22),
B(ReThrow),
@@ -1015,7 +975,7 @@ bytecodes: [
B(Ldar), R(20),
B(SetPendingMessage),
B(Ldar), R(18),
- B(SwitchOnSmiNoFeedback), U8(17), U8(2), I8(0),
+ B(SwitchOnSmiNoFeedback), U8(15), U8(2), I8(0),
B(Jump), U8(13),
B(LdaZero),
B(Star), R(14),
@@ -1036,7 +996,7 @@ bytecodes: [
B(Jump), U8(45),
B(Star), R(18),
B(Ldar), R(closure),
- B(CreateCatchContext), R(18), U8(10), U8(19),
+ B(CreateCatchContext), R(18), U8(10), U8(17),
B(Star), R(17),
B(LdaTheHole),
B(SetPendingMessage),
@@ -1071,7 +1031,7 @@ bytecodes: [
B(Ldar), R(16),
B(SetPendingMessage),
B(Ldar), R(14),
- B(SwitchOnSmiNoFeedback), U8(20), U8(2), I8(0),
+ B(SwitchOnSmiNoFeedback), U8(18), U8(2), I8(0),
B(Jump), U8(8),
B(Ldar), R(15),
/* 114 S> */ B(Return),
@@ -1082,8 +1042,8 @@ bytecodes: [
]
constant pool: [
Smi [102],
- Smi [424],
- Smi [540],
+ Smi [415],
+ Smi [522],
TUPLE2_TYPE,
SYMBOL_TYPE,
SYMBOL_TYPE,
@@ -1096,8 +1056,6 @@ constant pool: [
ONE_BYTE_INTERNALIZED_STRING_TYPE ["return"],
ONE_BYTE_INTERNALIZED_STRING_TYPE [""],
FIXED_ARRAY_TYPE,
- Smi [260],
- Smi [271],
Smi [6],
Smi [14],
FIXED_ARRAY_TYPE,
@@ -1105,11 +1063,11 @@ constant pool: [
Smi [9],
]
handlers: [
- [62, 712, 718],
- [65, 667, 669],
- [71, 333, 339],
- [74, 293, 295],
- [400, 494, 496],
+ [62, 685, 691],
+ [65, 640, 642],
+ [71, 324, 330],
+ [74, 284, 286],
+ [391, 476, 478],
]
---
« src/builtins/builtins-generator-gen.cc ('K') | « src/parsing/preparser.h ('k') | test/cctest/interpreter/bytecode_expectations/ForOfLoop.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698