Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2856)

Unified Diff: build/android/chrome_profiler/main.py

Issue 291723002: Add --trace-memory option for tracing heap memory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/chrome_profiler/chrome_controller.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/chrome_profiler/main.py
diff --git a/build/android/chrome_profiler/main.py b/build/android/chrome_profiler/main.py
index e3435d17fc9ecef2fff26c469f233de444dcc113..401115fb57d9cc5ffa590758458f1ec149ffbee1 100755
--- a/build/android/chrome_profiler/main.py
+++ b/build/android/chrome_profiler/main.py
@@ -32,6 +32,8 @@ def _ComputeChromeCategories(options):
categories.append('disabled-by-default-gpu.debug*')
if options.trace_flow:
categories.append('disabled-by-default-toplevel.flow')
+ if options.trace_memory:
+ categories.append('disabled-by-default-memory')
if options.chrome_categories:
categories += options.chrome_categories.split(',')
return categories
@@ -87,6 +89,9 @@ def _CreateOptionParser():
'for GPU data.', action='store_true')
chrome_opts.add_option('--trace-flow', help='Enable extra trace categories '
'for IPC message flows.', action='store_true')
+ chrome_opts.add_option('--trace-memory', help='Enable extra trace categories '
+ 'for memory profile. (tcmalloc required)',
+ action='store_true')
parser.add_option_group(chrome_opts)
systrace_opts = optparse.OptionGroup(parser, 'Systrace tracing options')
@@ -181,7 +186,8 @@ When in doubt, just try out --trace-frame-viewer.
chrome_controller.ChromeTracingController(device,
package_info,
chrome_categories,
- options.ring_buffer))
+ options.ring_buffer,
+ options.trace_memory))
if systrace_categories:
enabled_controllers.append(
systrace_controller.SystraceController(device,
« no previous file with comments | « build/android/chrome_profiler/chrome_controller.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698