Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: pkg/analyzer/lib/src/dart/analysis/driver.dart

Issue 2917183003: update the analyzer and analysis server perf tags (Closed)
Patch Set: updates for review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/dart/analysis/driver.dart
diff --git a/pkg/analyzer/lib/src/dart/analysis/driver.dart b/pkg/analyzer/lib/src/dart/analysis/driver.dart
index b4bac8b4eb193b553bdad46a7077179bb23856c6..5ea78027cd23070c820754a6b59fccb2946f7574 100644
--- a/pkg/analyzer/lib/src/dart/analysis/driver.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/driver.dart
@@ -25,8 +25,13 @@ import 'package:analyzer/src/dart/analysis/search.dart';
import 'package:analyzer/src/dart/analysis/status.dart';
import 'package:analyzer/src/dart/analysis/top_level_declaration.dart';
import 'package:analyzer/src/generated/engine.dart'
- show AnalysisContext, AnalysisEngine, AnalysisOptions;
+ show
+ AnalysisContext,
+ AnalysisEngine,
+ AnalysisOptions,
+ PerformanceStatistics;
import 'package:analyzer/src/generated/source.dart';
+import 'package:analyzer/src/generated/utilities_general.dart';
import 'package:analyzer/src/lint/registry.dart' as linter;
import 'package:analyzer/src/summary/format.dart';
import 'package:analyzer/src/summary/idl.dart';
@@ -36,6 +41,13 @@ import 'package:front_end/src/base/performace_logger.dart';
import 'package:front_end/src/incremental/byte_store.dart';
import 'package:meta/meta.dart';
+class DriverPerformance {
+ static final PerformanceTag driver =
+ PerformanceStatistics.analyzer.createChild('driver');
+
+ static final PerformanceTag cache = driver.createChild('cache');
+}
+
/**
* This class computes [AnalysisResult]s for Dart files.
*
@@ -978,7 +990,9 @@ class AnalysisDriver implements AnalysisDriverGeneric {
// If we don't need the fully resolved unit, check for the cached result.
if (!withUnit) {
- List<int> bytes = _byteStore.get(key);
+ List<int> bytes = DriverPerformance.cache.makeCurrentWhile(() {
+ return _byteStore.get(key);
+ });
if (bytes != null) {
return _getAnalysisResultFromBytes(file, signature, bytes);
}

Powered by Google App Engine
This is Rietveld 408576698